Catches IndexOutOfBoundsException occurring on edge cases #1078
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
antonis
added
bug
Gutenberg
geriux
approved these changes
Mar 22, 2024
geriux
left a comment
geriux
left a comment
There was a problem hiding this comment.
LGTM! I've tested different test cases and the editor works as expected 🚀
It makes sense to go with this approach.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes wordpress-mobile/WordPress-Android#20481
Related PRs:
Description
This PR adds exception handling for an
IndexOutOfBoundsExceptionthrown from theSpannableStringBuilderwhen the requested character position >= length on rare occasions.Test
I did not find a way to reproduce the issue. Thus I suggest a sanity check like the following:
Screen_recording_20240321_132332.mp4
Make sure strings will be translated:
strings.xmlas a part of the integration PR.