Skip to content

Commit 5ef65dd

Browse files
committed
fix(kitsu-core): return an empty string if splitModel is passed an empty url
1 parent e211c46 commit 5ef65dd

File tree

2 files changed

+7
-1
lines changed

2 files changed

+7
-1
lines changed

packages/kitsu-core/src/splitModel/index.js

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -31,7 +31,7 @@ export function splitModel (url, options = {}) {
3131
if (!options.resourceCase) options.resourceCase = s => s
3232

3333
const urlSegments = url.split('/')
34-
const resourceModel = urlSegments.pop()
34+
const resourceModel = urlSegments.pop() || ''
3535
urlSegments.push(options.pluralModel(options.resourceCase(resourceModel)))
3636
const newUrl = urlSegments.join('/')
3737

packages/kitsu-core/src/splitModel/index.spec.js

Lines changed: 6 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -61,5 +61,11 @@ describe('kitsu-core', () => {
6161
}))
6262
.toStrictEqual([ 'libraryEntry', 'library_entry' ])
6363
})
64+
65+
it('(empty) -> (empty)', () => {
66+
expect.assertions(1)
67+
expect(splitModel(''))
68+
.toStrictEqual([ '', '' ])
69+
})
6470
})
6571
})

0 commit comments

Comments
 (0)