fix: shape component fixes (Cross, Trapezoid, null guards)#16
Closed
muhammadrashid4587 wants to merge 1 commit into
Closed
fix: shape component fixes (Cross, Trapezoid, null guards)#16muhammadrashid4587 wants to merge 1 commit into
muhammadrashid4587 wants to merge 1 commit into
Conversation
- Cross: replace thick polygon with thin crosshair matching recharts - Trapezoid: fix alignment to top-aligned (matching recharts FunnelChart) - Rectangle/Sector/Dot: add null guards for invalid values - polar-utils: unify polarToCartesian to use 12-o'clock = 0° convention Closes wook95#8, closes wook95#14 Co-Authored-By: Claude Opus 4.6 <[email protected]>
Owner
|
Hey, thanks for the work on this! That said, your fix for polar-utils is a nice catch. If #15 doesn't cover it, would you be open to splitting that out into a separate PR for #14? Thanks! |
Owner
|
Update: #15 ended up covering the polar-utils fix too, so that's all merged now. Closing this — thanks again for jumping in! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
M{x},{top}v{height}M{left},{y}h{width}) matching recharts originalCloses #8
Test plan
🤖 Generated with Claude Code