Skip to content

Fixed notice of undefined $result. #9

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
gedex merged 1 commit into from
May 23, 2016
Merged

Fixed notice of undefined $result. #9

gedex merged 1 commit into from
May 23, 2016

Conversation

@gedex
Copy link
Member

@gedex gedex commented May 23, 2016 •
edited
Loading

Fixes #5.

Changes proposed in this Pull Request:

  • Uses $responses instead of $result which is undefined
  • Make sure your changes respect WordPress' coding standards.
  • Did you make changes, or create a new .js file? If Gruntfile.js exists in the repo, make sure to run grunt.

@gedex
Copy link
Member Author

gedex commented May 23, 2016

@roykho please review.

@roykho
Copy link
Contributor

roykho commented May 23, 2016

LGTM

@gedex gedex merged commit 1ddfc06 into master May 23, 2016
@gedex gedex deleted the issues/5/fix-notice branch May 23, 2016 18:02
@jabba2324 jabba2324 mentioned this pull request Nov 28, 2017
Closed
@yukikatayama yukikatayama mentioned this pull request Oct 22, 2019
Closed
@dougaitken dougaitken mentioned this pull request May 18, 2020
Closed
@slash1andy slash1andy mentioned this pull request Aug 7, 2020
Closed
@reykjalin reykjalin mentioned this pull request Oct 19, 2021
Closed
3 tasks
@colmtroy colmtroy mentioned this pull request Nov 18, 2021
Closed
@gglobalstep gglobalstep mentioned this pull request Dec 3, 2021
Closed
3 tasks
@gglobalstep gglobalstep mentioned this pull request Jan 21, 2022
Closed
3 tasks
@selectedselections selectedselections mentioned this pull request May 2, 2022
Open
5 tasks
@DaniyarIsmailov DaniyarIsmailov mentioned this pull request Oct 25, 2022
Closed
2 tasks
@isaklafleur isaklafleur mentioned this pull request Nov 21, 2022
Closed
@dineshinau dineshinau mentioned this pull request Jan 22, 2023
Closed
@gglobalstep gglobalstep mentioned this pull request Feb 2, 2023
Closed
3 tasks
@imodouglas imodouglas mentioned this pull request Nov 6, 2023
Closed
This was referenced Feb 5, 2024
Closed
Closed
This was referenced Feb 26, 2024
Closed
Closed
@marcus-abrahamsson marcus-abrahamsson mentioned this pull request Mar 28, 2024
Closed
@nicdwilson nicdwilson mentioned this pull request May 21, 2024
Closed
@gglobalstep gglobalstep mentioned this pull request Jul 9, 2024
Closed
3 tasks
@ahawtin ahawtin mentioned this pull request Dec 13, 2025
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

pr: ready to merge

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@gedex @roykho