Allow customizing the label and description of the UPE payment methods #3176
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Mayisha
requested review from
a team and
diegocurbelo
and removed request for
a team
diegocurbelo
requested changes
Jun 6, 2024
Member
diegocurbelo
left a comment
diegocurbelo
left a comment
There was a problem hiding this comment.
Thanks for working on this @Mayisha.
The code looks good, I think we should check if UPE is enabled server-side it would make the code cleaner.
It works great in the new checkout experience:
It also works with empty titles/description:
The only detail is the position of the customize button with payment methods with short descriptions like Klarna... we need to align the button to the right.
Contributor
Author
|
Thanks @diegocurbelo 🚀 I have fixed the button in 0efdc2d and now I am checking the UPE status on the server side which is fixed in 048c2f4. |
diegocurbelo
approved these changes
Jun 9, 2024
Member
diegocurbelo
left a comment
diegocurbelo
left a comment
There was a problem hiding this comment.
Thanks for making the changes @Mayisha!
Looks great now! 🚢
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #2993
In legacy experience, merchants can customize the title and description of the payment methods and they are also reflected on the checkout page. This feature was missing from the new checkout experience. In this PR, I have added the ability to customize the title and description of the payment methods when UPE is enabled.
Changes proposed in this Pull Request:
woocommerce_stripe_ideal_settings,woocommerce_stripe_eps_settingsetc.Testing instructions
developbranch, there is noCustomizebutton beside the payment methods. In this branch, you should see aCustomizebutton beside each payment method.Customizebutton of a payment method and confirm that it has a title and description populated which was saved as part of the legacy experience. (This is true for the payment method existing in legacy experience, not for the new methods like klarna or afterpay)Save changes. Reload the page and confirm that the changes persist.Shortcode
Block