This repository was archived by the owner on Feb 23, 2024. It is now read-only.
Fix Mini-Cart block conflict with Page Optimize and Product Bundles (II) #9586
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
woocommercebot
requested review from
a team and
roykho
and removed request for
a team
Aljullu
added
status: needs review
type: bug
Contributor
|
The release ZIP for this PR is accessible via: TypeScript Errors Report
assets/js/atomic/blocks/product-elements/button/block.tsx
assets/js/atomic/blocks/product-elements/button/supports.ts assets/js/base/components/drawer/index.tsx assets/js/base/hooks/use-border-props.ts assets/js/base/hooks/use-color-props.ts assets/js/base/hooks/use-spacing-props.ts assets/js/blocks/mini-cart/edit.tsx assets/js/blocks/mini-cart/mini-cart-contents/inner-blocks/mini-cart-footer-block/block.tsx assets/js/blocks/product-search/block.js assets/js/blocks/product-search/edit.js assets/js/data/utils/has-in-state.js assets/js/data/utils/update-state.js Script Dependencies ReportThe
This comment was automatically generated by the |
github-actions
bot
added
status: ready to merge
and removed
status: needs review
labels
Contributor
|
Size Change: 0 B Total Size: 1.1 MB ℹ️ View Unchanged
|
4 tasks
Contributor
|
I am not sure if I am missing a step but I am still seeing the error. Note that I replaced the |
Contributor
Author
|
@roykho if you go to |
Contributor
|
@Aljullu yes and yes |
Contributor
Author
|
@roykho I would say somewhere in the codebase there is still a 10.0.4 reference. Can you make sure the versions in these files are set to 10.0.5 before running |
Contributor
I suggest using: |
Contributor
|
Ok so in my VS code workspace, I have both repos in there and search and replace all do both. That caused the issue. All good now. |
4 tasks
Contributor
Author
|
Thanks for the reviews, folks! Some automations are failing in this PR, but:
Based on that, I will go ahead and merge and continue with the 10.0.5 release. |
Aljullu
added a commit
that referenced
this pull request
May 25, 2023
Aljullu
added a commit
that referenced
this pull request
May 25, 2023
* Empty commit for release pull request * Add 10.2.1 changelog * Update versions to 10.2.1 * Fix Mini-Cart block conflict with Page Optimize and Product Bundles (II) (#9586) * Add 10.2.1 testing steps --------- Co-authored-by: github-actions <[email protected]> Co-authored-by: Albert Juhé Lluveras <[email protected]>
4 tasks
Aljullu
added a commit
that referenced
this pull request
May 30, 2023
* Empty commit for release pull request * Fix Mini-Cart block conflict with Page Optimize and Product Bundles (II) (#9586) * Add 10.0.5 changelog * Update versiosn to 10.0.5 * Fix 10.0.4 testing notes markdown * Add 10.0.5 testing notes --------- Co-authored-by: github-actions <[email protected]> Co-authored-by: Albert Juhé Lluveras <[email protected]>
7 tasks
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #9584.
Supersets #9585.
This PR ports the change introduced in #8979 to WC Blocks 10.0.x. It also modifies the status we compare against (
enqueuedinstead ofdone), so we match any enqueued script, even if it hasn't been printed yet.Testing
User Facing Testing
10.0.4with10.0.5in the codebase and runcomposer i. Otherwise, WC core wouldn't load WC Blocks from the feature plugin.WooCommerce Visibility
Changelog