This repository was archived by the owner on Feb 23, 2024. It is now read-only.
Mini Cart block: exclude already-printed scripts from scripts to lazy load #8979
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Aljullu
added
status: needs review
focus: performance
woocommercebot
requested review from
a team and
imanish003
and removed request for
a team
Contributor
|
The release ZIP for this PR is accessible via: Script Dependencies ReportThere is no changed script dependency between this branch and trunk. This comment was automatically generated by the TypeScript Errors Report
🎉 🎉 This PR does not introduce new TS errors. |
Contributor
|
Size Change: 0 B Total Size: 1.11 MB ℹ️ View Unchanged
|
Aljullu
force-pushed
the
fix/mini-cart-exclude-enqueued-files-from-lazy-load
branch
from
61326df to
8a5ee8d
Compare
Aljullu
changed the title
imanish003
suggested changes
Apr 7, 2023
Contributor
There was a problem hiding this comment.
Hi @Aljullu,
The code changes look good to me, but while following testing instructions, I am seeing:
- All Products block page: wcBlocksMiniCartFrontendDependencies['wp-i18n'] is undefined.
- Page with no blocks: wcBlocksMiniCartFrontendDependencies['wp-i18n'] is defined
Maybe I am doing something wrong while testing on my local setup? 🤷🏻♂️
Screen.Recording.2023-04-07.at.11.48.21.AM.mov
Contributor
Author
My bad, that was me writing the testing steps incorrectly. 🤦♂️ What you can reproduce is the expected behavior:
I updated the testing steps accordingly. Sorry for the confusion! 🙏 |
Contributor
|
@Aljullu, no problem. Thanks for the clarification and updating the testing steps. I'm going to approve it now since I've already tested it 🙂 |
github-actions
bot
added
status: ready to merge
and removed
status: needs review
labels
Aljullu
force-pushed
the
fix/mini-cart-exclude-enqueued-files-from-lazy-load
branch
from
8e7c188 to
f98cb43
Compare
thealexandrelara
added
the
skip-changelog
4 tasks
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The Mini Cart block registers an object (
scripts_to_lazy_load) where we store all scripts that we need to lazy load. This PR makes it a bit more clever, so if a script is already printed (ie: another block has enqueued it), it will not be added to the scripts to lazy load.Testing
User Facing Testing
Object.keys( wcBlocksMiniCartFrontendDependencies ).lengthandwcBlocksMiniCartFrontendDependencies['wp-i18n'].wcBlocksMiniCartFrontendDependencies['wp-i18n']is defined.wcBlocksMiniCartFrontendDependencies['wp-i18n']is undefined andObject.keys( wcBlocksMiniCartFrontendDependencies ).lengthis smaller.WooCommerce Visibility
Changelog