Skip to content
This repository was archived by the owner on Feb 23, 2024. It is now read-only.

Ignore shipping address from server when updating shipping methods #8718

Merged
Aljullu merged 1 commit into from
Mar 14, 2023
Merged

Ignore shipping address from server when updating shipping methods #8718

Aljullu merged 1 commit into from
Mar 14, 2023

Conversation

@mikejolley
Copy link
Member

@mikejolley mikejolley commented Mar 13, 2023

Uses receiveCartContents to prevent address data overwriting data in the client.

Testing

User Facing Testing

  1. Fill out your shipping address. Wait a few moments for it to persist to server.
  2. Clear the first name field. There will be a validation error.
  3. Select a different shipping method.
  4. When the totals are updated, confirm the first name field is still empty.

WooCommerce Visibility

  • WooCommerce Core
  • Feature plugin
  • Experimental

Changelog

Prevent address data being overwritten when changing shipping methods.

@mikejolley mikejolley changed the base branch from trunk to release/9.8.0 March 13, 2023 15:18
@mikejolley mikejolley requested a review from tarunvijwani March 13, 2023 15:33
@ralucaStan ralucaStan added priority: high The issue/PR is high priority—it affects lots of customers substantially, but not critically. status: blocker Used on issues or pulls that block work from being released. labels Mar 13, 2023
@Aljullu Aljullu added this to the 9.8.0 milestone Mar 13, 2023
tarunvijwani
tarunvijwani approved these changes Mar 13, 2023
View reviewed changes
Copy link

@tarunvijwani tarunvijwani left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for the quick fix, @mikejolley! It works great. 🎉

@Aljullu Aljullu merged commit 5490c33 into release/9.8.0 Mar 14, 2023
@Aljullu Aljullu deleted the fix/ignore-shipping-address-from-server branch March 14, 2023 09:18
@ralucaStan ralucaStan mentioned this pull request Mar 17, 2023
Merged
7 tasks
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

1 more reviewer

@tarunvijwani tarunvijwani tarunvijwani approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

priority: high The issue/PR is high priority—it affects lots of customers substantially, but not critically. status: blocker Used on issues or pulls that block work from being released.

Projects

None yet

Milestone

9.8.0

Development

Successfully merging this pull request may close these issues.

4 participants

@mikejolley @tarunvijwani @ralucaStan @Aljullu