This repository was archived by the owner on Feb 23, 2024. It is now read-only.
Update @wordpress/components and merge into single dependency #7962
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
|
The release ZIP for this PR is accessible via: |
Contributor
TypeScript Errors ReportFiles with errors: 419 Detailsassets/js/base/components/button/index.tsxpackages/checkout/slot/index.js |
Contributor
|
Size Change: -175 kB (-17%) 👏 Total Size: 836 kB
ℹ️ View Unchanged
|
Contributor
Script Dependencies ReportThe
This comment was automatically generated by the |
kmanijak
changed the title
1 task
Contributor
|
The release ZIP for this PR is accessible via: Script Dependencies ReportThe
This comment was automatically generated by the TypeScript Errors Report
Detailsassets/js/base/components/button/index.tsx |
Contributor
|
This PR has been marked as If deemed still relevant, the pr can be kept active by ensuring it's up to date with the main branch and removing the stale label. |
github-actions
bot
added
the
status: stale
* Update FormTokenField styles after @wordpress/components update * Remove unnecessary CSS declarations
github-actions
bot
removed
the
status: stale
Contributor
Author
|
That path won't be followed, hence closing the PR |
nielslange
deleted the
try/update-wordpress-components-no-framer-motion
branch
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Background
WooCommerce Blocks relies on
@wordpress/componentsin two ways:What PR does
This PR updates the
@wordpress/componentsto version 22.0.0 and narrow down the dependency to single one with no difference between Editor and the FrontendWhat PR does not
Current newest version of
@wordpress/componentsis 23.0.0. This PR does not update the dependency to the newest version, since version 23.0.0 relies on React 18, while we rely on React 17. Although, the update of React may be easy I believe it deserves a separate PR.Also, I encountered problems with build with version 22.1.0 of
@wordpress/components(missing SCSS variable), hence I sticked to 22.0.0. I believe the key problem was to bump it as far as possible and then fix the following issues from there.Fixes #7665
Fixes #7950
Fixes #5611
Accessibility
prefers-reduced-motionUser Facing Testing
Impacted blocks/components should be smoke tested (and overall monkey tested).
WooCommerce Visibility
Performance Impact
Changelog