This repository was archived by the owner on Feb 23, 2024. It is now read-only.
Fix error when trying to access the queried object when it's null #7664
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
albarin
added
skip-changelog
Contributor
|
The release ZIP for this PR is accessible via: |
Contributor
TypeScript Errors ReportFiles with errors: 440 🎉 🎉 This PR does not introduce new TS errors. |
Contributor
|
Size Change: 0 B Total Size: 990 kB ℹ️ View Unchanged
|
Contributor
Script Dependencies ReportThere is no changed script dependency between this branch and trunk. This comment was automatically generated by the |
Aljullu
approved these changes
Nov 11, 2022
Contributor
Aljullu
left a comment
Aljullu
left a comment
There was a problem hiding this comment.
I was struggling to reproduce the reported issue, but I finally could. It turns out it's only reproducible in block themes.
Anyway, confirming this PR fixes it. 👌 Thanks, Alba!
Contributor
Author
Thanks 🙏 |
senadir
pushed a commit
to senadir/woocommerce-blocks
that referenced
this pull request
Nov 12, 2022
…ocommerce#7664) * Fix error when trying to access the queried object when it's null. * Check if the `slug` exists * Use the taxonomy name instead of the slug, otherwise it returns false
albarin
added a commit
that referenced
this pull request
Nov 14, 2022
* Empty commit for release pull request * Display correct block template when filtering by attribute (#7640) * Fix error when trying to access the queried object when it's null (#7664) * Fix error when trying to access the queried object when it's null. * Check if the `slug` exists * Use the taxonomy name instead of the slug, otherwise it returns false * Update readme changelog * Add testing notes * Improve testing notes format * Bumping version strings to new version. Co-authored-by: github-actions <[email protected]> Co-authored-by: Albert Juhé Lluveras <[email protected]> Co-authored-by: Alba Rincón <[email protected]> Co-authored-by: Alba Rincón <[email protected]>
gigitux
added a commit
that referenced
this pull request
Dec 1, 2022
* Empty commit for release pull request * Display correct block template when filtering by attribute (#7640) * Fix error when trying to access the queried object when it's null (#7664) * Fix error when trying to access the queried object when it's null. * Check if the `slug` exists * Use the taxonomy name instead of the slug, otherwise it returns false * Update readme changelog * Add testing notes * Improve testing notes format * Bumping version strings to new version. * Prevent Mini Cart loading the same script twice (#7794) * Empty commit for release pull request * update changelog * add testing instructions * update zip file link * Mini Cart: load wc-blocks-registry package at the load of the page instead of lazy load it (#7813) * update changelog * update testing instructions * update zip file link * Bumping version strings to new version. Co-authored-by: github-actions <[email protected]> Co-authored-by: Albert Juhé Lluveras <[email protected]> Co-authored-by: Alba Rincón <[email protected]> Co-authored-by: Alba Rincón <[email protected]> Co-authored-by: Luigi <[email protected]>
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixed an error caused by trying to access the
slugattribute on a null object.Also changed
slugbytaxonomy, otherwise, thetaxonomy_is_product_attributewould always return false.Testing
The error is no longer there
trunk, go to the homepage of your site and see theWarning: Attempt to read property "slug" on null in /plugins/woocommerce-blocks/src/BlockTemplatesController.php on line 438errorThe archive product template loads
WooCommerce Visibility