This repository was archived by the owner on Feb 23, 2024. It is now read-only.
Use TT3 theme background for the Mini Cart background color #7503
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Aljullu
added
status: needs review
type: bug
rubikuserbot
requested review from
a team and
dinhtungdu
and removed request for
a team
Contributor
|
The release ZIP for this PR is accessible via: |
Contributor
|
Size Change: +80 B (0%) Total Size: 992 kB
ℹ️ View Unchanged
|
dinhtungdu
reviewed
Oct 27, 2022
Member
dinhtungdu
left a comment
dinhtungdu
left a comment
There was a problem hiding this comment.
@Aljullu Actually, we have the same issue for TT2, see attached screenshot. So addressing this issue per theme doesn't sound ideal to me as well. In #7510, I experiment with setting the background color of the Mini Cart Contents using the current body background color. Can you please check and let me know what you think?
Screenshot
7 tasks
Contributor
Author
|
Closing this one in favor of #7510. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #7501.
I'm not a big fan of this solution because we need to add custom CSS for TT3. I guess ideally there would be a way to semantically access the
bodybackground color in order to be able to use it in order elements. But I couldn't find a way to achieve that. 😞Screenshots
Testing
Automated Tests
User Facing Testing
Edit Mini Cart template partin the sidebar. That will open the template editor.WooCommerce Visibility
Changelog