This repository was archived by the owner on Feb 23, 2024. It is now read-only.
Register new footer patterns #7306
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rubikuserbot
requested review from
danielwrobert
and removed request for
a team
Contributor
|
The release ZIP for this PR is accessible via: |
Contributor
|
Size Change: 0 B Total Size: 917 kB ℹ️ View Unchanged
|
Contributor
|
Hey @imanish003 , the only issue I found is with the Are you able to reproduce? 🤔 |
Contributor
Author
@albarin Yes, I can reproduce it. Thanks for pointing this out 🙏 Looks like setting IMO we should set it to Here is how setting it to wide width will look like on large screens What do you think? 🙂 |
Contributor
Look better now, thanks for working on it! |
Contributor
Author
|
@albarin FYI just pushed a fix. Can you please have a look? 🙌🏻 |
tarhi-saad
pushed a commit
to tarhi-saad/woocommerce-gutenberg-products-block
that referenced
this pull request
Oct 31, 2022
* Register new footer patterns * Capitalize the footer word * Fix large footer pattern content cut-off issue For more info: woocommerce/woocommerce-blocks#7306 (comment) woocommerce/woocommerce-blocks#7306 (comment) Co-authored-by: Alba Rincón <[email protected]>
senadir
pushed a commit
to senadir/woocommerce-blocks
that referenced
this pull request
Nov 12, 2022
* Register new footer patterns * Capitalize the footer word * Fix large footer pattern content cut-off issue For more info: woocommerce#7306 (comment) woocommerce#7306 (comment) Co-authored-by: Alba Rincón <[email protected]>
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR registers 6 new footer patterns:
Fixes #7284
Testing
Automated Tests
User Facing Testing
WooCommerce Visibility
Changelog