This repository was archived by the owner on Feb 23, 2024. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 215
Prevent infinite loop when initialising the payments data store in the editor. #7256
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
|
The release ZIP for this PR is accessible via: |
alexflorisca
approved these changes
Sep 29, 2022
Contributor
alexflorisca
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good work spotting this, looks good 👍
Contributor
|
Size Change: 0 B Total Size: 959 kB ℹ️ View Unchanged
|
tarunvijwani
approved these changes
Oct 3, 2022
a084301 to
56eed6c
Compare
senadir
pushed a commit
to senadir/woocommerce-blocks
that referenced
this pull request
Nov 12, 2022
…e editor. (woocommerce#7256) * Unsubscribe the editor from changes when store is initialised * Use correct action to initialize payment store
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Labels
block: cart
Issues related to the cart block.
block: checkout
Issues related to the checkout block.
focus: blocks
Specific work involving or impacting how blocks behave.
focus: performance
The issue/PR is related to performance.
type: bug
The issue/PR concerns a confirmed bug.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR will ensure that the subscription to the
wc/store/payment-methodswhich was implemented to correctly display payment methods in the Checkout block in the editor is unsubscribed once the store is initialised.Previously, this was never unsubscribed so we saw errors like
RangeError: Maximum call stack size exceededascheckPaymentMethodsCanPaywas executed every time the store changed.Testing
Automated Tests
User Facing Testing
RangeError: Maximum call stack size exceededor similar appear.WooCommerce Visibility
Performance Impact
Changelog