This repository was archived by the owner on Feb 23, 2024. It is now read-only.
Document the selectors for the wc/store/checkout data store #7085
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nielslange
added
status: needs review
focus: documentation
rubikuserbot
requested review from
a team and
tarhi-saad
and removed request for
a team
Contributor
|
The release ZIP for this PR is accessible via: |
Contributor
|
Size Change: 0 B Total Size: 893 kB ℹ️ View Unchanged
|
opr
reviewed
Sep 8, 2022
docs/third-party-developers/extensibility/data-store/checkout.md
Outdated
Show resolved
Hide resolved
docs/third-party-developers/extensibility/data-store/checkout.md
Outdated
Show resolved
Hide resolved
docs/third-party-developers/extensibility/data-store/checkout.md
Outdated
Show resolved
Hide resolved
docs/third-party-developers/extensibility/data-store/checkout.md
Outdated
Show resolved
Hide resolved
alexflorisca
reviewed
Sep 8, 2022
Contributor
There was a problem hiding this comment.
Nice work @nielslange, this looks good but let's wait to make a decision on how we continue with the data store work based on pdFofs-fT-p2
Contributor
Author
Sure, @alexflorisca. |
opr
suggested changes
Sep 15, 2022
Contributor
opr
left a comment
opr
left a comment
There was a problem hiding this comment.
Thanks for documenting these selectors, Niels! Just a couple of comments and we should be good to go 👏🏼
docs/third-party-developers/extensibility/data-store/checkout.md
Outdated
Show resolved
Hide resolved
docs/third-party-developers/extensibility/data-store/checkout.md
Outdated
Show resolved
Hide resolved
docs/third-party-developers/extensibility/data-store/checkout.md
Outdated
Show resolved
Hide resolved
alexflorisca
approved these changes
Sep 22, 2022
Contributor
There was a problem hiding this comment.
Yeah, thanks for making those changes Niels, makes sense to leave it as you have it. Good work, everything looks good 👍 Let's wait to merge this until we merge the data store work into trunk though otherwise it will document things that aren't yet there! Would you mind changing the branch that it gets merged into from trunk to feature/data-store-refactor
github-actions
bot
added
status: ready to merge
and removed
status: needs review
labels
nielslange
changed the base branch from
trunk
to
feature/data-store-refactor
nielslange
changed the base branch from
feature/data-store-refactor
to
trunk
nielslange
force-pushed
the
add/add-external-docs-for-the-wc-store-checkout-data-store
branch
from
23ea7ed to
329884c
Compare
nielslange
changed the base branch from
trunk
to
feature/data-store-refactor
nielslange
deleted the
add/add-external-docs-for-the-wc-store-checkout-data-store
branch
Contributor
Author
Thanks for your review, @alexflorisca. I just rebased this PR from |
alexflorisca
pushed a commit
that referenced
this pull request
Sep 28, 2022
alexflorisca
pushed a commit
that referenced
this pull request
Sep 28, 2022
alexflorisca
pushed a commit
that referenced
this pull request
Sep 28, 2022
senadir
pushed a commit
to senadir/woocommerce-blocks
that referenced
this pull request
Nov 12, 2022
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #6945
Notes
In #6612, we ran a Data Store Migration. This PR aims to create the external documentation for the
wc/store/checkoutdata store.Testing
checkout.mdfrom this PR documents all selector that appear in the document mentioned before.