This repository was archived by the owner on Feb 23, 2024. It is now read-only.
Fix pills in the Filter by Attribute block dropdown overlapping with the chevron
#7039
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
albarin
added
skip-changelog
Contributor
|
The release ZIP for this PR is accessible via: |
rubikuserbot
requested review from
a team and
sunyatasattva
and removed request for
a team
Contributor
|
Size Change: +27 B (0%) Total Size: 872 kB
ℹ️ View Unchanged
|
Aljullu
approved these changes
Sep 2, 2022
Contributor
Aljullu
left a comment
Aljullu
left a comment
There was a problem hiding this comment.
Confirming it fixes the issue! I left one small comment about using calc() for the input width, but LGTM.
This was referenced Sep 12, 2022
senadir
pushed a commit
to senadir/woocommerce-blocks
that referenced
this pull request
Nov 12, 2022
…h the chevron (woocommerce#7039) * Avoid chevron overlap * Improve input width calculation
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix the chevron overlap with the attribute pills in some smaller window sizes.
Fixes #6982
Screenshots
Testing
User Facing Testing
Filter by Attributeblock and theAll Productsblock to a page.Filter by Attributeblock display to dropdown and allow selecting multiple options.WooCommerce Visibility