This repository was archived by the owner on Feb 23, 2024. It is now read-only.
Turn current page into the default Cart/Checkout page #6867
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
senadir
added
type: enhancement
senadir
force-pushed
the
add/set-cart-as-default
branch
from
d45463b to
86d3cad
Compare
Contributor
|
The release ZIP for this PR is accessible via: |
Contributor
Script Dependencies ReportThe
This comment was automatically generated by the |
Contributor
|
Size Change: +1.21 kB (0%) Total Size: 869 kB
ℹ️ View Unchanged
|
senadir
requested review from
a team and
tarunvijwani
and removed request for
a team
ralucaStan
removed
the
status: blocker
senadir
force-pushed
the
add/set-cart-as-default
branch
2 times, most recently
from
7ae3d74 to
eeebaf8
Compare
senadir
commented
Aug 12, 2022
Comment on lines
64
to
77
| <DefaultNotice | ||
| block={ isCheckout ? 'checkout' : 'cart' } | ||
| /> | ||
| <DefaultNotice | ||
| <CartCheckoutSidebarCompatibilityNotice |
Member
Author
There was a problem hiding this comment.
Switched to follow design.
Comment on lines
+19
to
+40
| const ORIGINAL_PAGE_ID = | ||
| block === 'checkout' ? CHECKOUT_PAGE_ID : CART_PAGE_ID; | ||
| const settingName = | ||
| block === 'checkout' | ||
| ? 'woocommerce_checkout_page_id' | ||
| : 'woocommerce_cart_page_id'; | ||
|
|
||
| const noticeContent = | ||
| block === 'checkout' | ||
| ? __( | ||
| 'If you would like to use this block as your default checkout, update your page settings', | ||
| 'woo-gutenberg-products-block' | ||
| ) | ||
| : __( | ||
| 'If you would like to use this block as your default cart, update your page settings', | ||
| 'woo-gutenberg-products-block' | ||
| ); |
Member
Author
There was a problem hiding this comment.
We handle Cart and Checkout from this component, everything is the same we just need to have 2 different values.
Comment on lines
-36
to
-46
| <div | ||
| className="wc-blocks-sidebar-compatibility-notice" | ||
| style={ { display: isVisible ? 'block' : 'none' } } | ||
| <Notice | ||
| onRemove={ dismissNotice } | ||
| className={ classnames( [ | ||
| 'wc-blocks-sidebar-compatibility-notice', | ||
| { 'is-hidden': ! isVisible }, | ||
| ] ) } | ||
| > | ||
| <Notice | ||
| onRemove={ dismissNotice } | ||
| className={ 'wc-blocks-sidebar-compatibility-notice__notice' } | ||
| > | ||
| { noticeText } | ||
| </Notice> | ||
| </div> |
senadir
force-pushed
the
add/set-cart-as-default
branch
from
70e803b to
7167194
Compare
Contributor
|
Based on the internal conversation p1660321370894249/1660311130.074619-slack-C8X6Q7XQU we will need to change the implementation:
|
senadir
commented
Aug 12, 2022
Comment on lines
+67
to
+76
| { isWcVersion( '6.9.0', '>=' ) ? ( | ||
| <DefaultNotice | ||
| block={ isCheckout ? 'checkout' : 'cart' } | ||
| /> | ||
| ) : ( | ||
| <LegacyNotice | ||
| block={ isCheckout ? 'checkout' : 'cart' } | ||
| /> | ||
| ) } | ||
|
|
Member
Author
There was a problem hiding this comment.
This logic should handle older versions which doesn't support the setting needed.
|
@senadir Thank you for working on it. If I add a Checkout block and use a button to update the settings, it changes the slug to Screen.Recording.2022-08-19.at.4.34.12.PM.movFor the Cart page, it is not updating the slug for me: Screen.Recording.2022-08-19.at.4.37.13.PM.mov |
Member
Author
|
Can you please remove any existing saved Cart/Checkout page settings you have, it seems your previously default Checkout page has a |
senadir
force-pushed
the
add/set-cart-as-default
branch
from
70708b2 to
4e4cc33
Compare
Contributor
|
Thank you for your review, @tarunvijwani! I'm merging this PR to include it in the 8.4.0 release! |
senadir
added a commit
to senadir/woocommerce-blocks
that referenced
this pull request
Nov 12, 2022
* Add default page notice * show notice all inner blocks * support flow when page isnt saved * switch from where we get the current post id * update lock * fix types * update logic to support cart as well * fix package.json * update design and move away from wc.data * restore notice * handle older versions of WooCommerce * fix package lock * fix typo
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds a "make current page default cart/checkout", it has a long flow that goes via several conditions:
To test this PR, you need this PR from to have the latest trunk of WooCommerce, or WooCommerce 6.9.0
For older versions of WC (pre 6.9.0), the notice would show the old text
Fixes #6864
Fixes #6865
Screenshots
Screen.Recording.2022-08-05.at.23.35.20.mov
User Facing Testing
/cartand/checkout./cart.WooCommerce Visibility
Changelog