This repository was archived by the owner on Feb 23, 2024. It is now read-only.
SearchListControl: Fix preserving case of original item
#6551
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sunyatasattva
added
type: bug
rubikuserbot
requested review from
a team and
tomasztunik
and removed request for
a team
Contributor
Script Dependencies ReportThe
This comment was automatically generated by the |
Contributor
|
Size Change: +102 B (0%) Total Size: 873 kB
ℹ️ View Unchanged
|
Aljullu
approved these changes
Jul 12, 2022
Contributor
Aljullu
left a comment
Aljullu
left a comment
There was a problem hiding this comment.
This is testing well and code looks good, thanks for fixing this @sunyatasattva!
I'm pre-approving, but I left a comment about whether we should import from react or from @wordpress/element. It looks like the way this PR is done, it's currently adding the react dependency to several scripts.
| * External dependencies | ||
| */ | ||
| import { groupBy, keyBy } from 'lodash'; | ||
| import { Fragment } from 'react'; |
Contributor
There was a problem hiding this comment.
I'm a bit confused by this now, but I thought we always wanted to prioritize importing from @wordpress/element instead of react.
Contributor
Author
There was a problem hiding this comment.
Oh thanks for pointing that out @Aljullu! I wasn't aware of that. Perhaps it's something we could write somewhere? Team Handbook? READMEs?
I'll fix it and merge it! Thanks for the review! 🙏
Contributor
There was a problem hiding this comment.
Oh thanks for pointing that out @Aljullu! I wasn't aware of that. Perhaps it's something we could write somewhere? Team Handbook? READMEs?
Sounds good, I agree. Is that something you can own or create an issue with the documentation label?
Searches would keep the case of the user input instead of the original case of the name.
sunyatasattva
force-pushed
the
fix/6524-search-list-control-preserving-input-case
branch
from
b461883 to
afce2fd
Compare
sunyatasattva
deleted the
fix/6524-search-list-control-preserving-input-case
branch
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes an issue where the
SearchListControlcomponent (for example, used in the Hand-picked Products block) would render the search results list with highlighted text borrowing the case from the user's input instead of the original item's name. So, if the original item's name wasHoodie, but the user's input washOoDiE, search results would display the latter, rather than the former.Search still is case insensitive, but preserves the original item's case.
Also, this PR adds a test for this bug and fixes a previous test case which wasn't actually testing for this at all.
Fixes #6524
Screenshots
Testing
Automated Tests
User Facing Testing
WooCommerce Visibility
Performance Impact
Changelog