This repository was archived by the owner on Feb 23, 2024. It is now read-only.
Featured items: ensure valid DOM nesting in inspector controls #6501
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
frontdevde
added
the
skip-changelog
Contributor
|
Size Change: +50 B (0%) Total Size: 862 kB
ℹ️ View Unchanged
|
sunyatasattva
approved these changes
May 31, 2022
Contributor
sunyatasattva
left a comment
sunyatasattva
left a comment
There was a problem hiding this comment.
Thanks for spotting this! I wonder why I couldn't reproduce and how come we didn't notice earlier, as this change was introduced at the beginning of the project.
But thanks for the fix. I'm more a fan of giving these spans a className (like help-text or something) and styling them through CSS, but I don't have a strong stance on this, so I'm approving.
Contributor
Author
Usually, I'd 100% agree. This is in the editor sidebar though. I'd argue we'd want to keep the styling surface to an absolute minimum there and providing an additional class that folks could attach more styles to could be a precedent we don't want. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is a follow-up on one of a couple of small issues we discovered since the recent updates of the featured item blocks (the other issue was fixed in #6499).
This PR aims to resolve a console error that's being thrown when interacting with the Featured Product/Category blocks. The issue occurred in the help text being added in the editor sidebar. It was caused by a block-level element being included in a
<p>element, which must only contain inline containers.Screenshots
Testing
Featured Productor aFeatured Categoryblock and open the console.