This repository was archived by the owner on Feb 23, 2024. It is now read-only.
Add descriptions for all WC templates and refactor Search template hierarchy loading logic #6345
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
danieldudzic
added
the
focus: template
Contributor
|
Size Change: 0 B Total Size: 866 kB ℹ️ View Unchanged
|
gigitux
suggested changes
Apr 29, 2022
Contributor
gigitux
left a comment
gigitux
left a comment
There was a problem hiding this comment.
Good job! It isn't easy work with this part of the project :)
I added some comments and it would be cool if @tjcafferkey takes a look too.
tjcafferkey
reviewed
Apr 29, 2022
Contributor
I reiterate this statement, this is definitely not the easiest code to work with so well done for navigating this @danieldudzic !
I have left some comments, I am AFK on Monday but will test again on Tuesday 😄 |
tjcafferkey
reviewed
Apr 29, 2022
gigitux
suggested changes
May 13, 2022
14 tasks
gigitux
suggested changes
Jun 9, 2022
Contributor
gigitux
left a comment
gigitux
left a comment
There was a problem hiding this comment.
I guess that we could use ProductSearchResults::SLUG in other places too.
Not sure about ProductSearchResults::TITLE and ``ProductSearchResults::DESCRIPTION` because they could not work with translations.
…ocks into update/6233-template-details-loading-logic
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR updates the way template titles and descriptions are being loaded, by mirroring how WP core is doing it, moving the relevant code to the
BlockTemplateUtils.phpfile. In addition, it moves Search template hierarchy loading logic toBlockTemplatesController.php.Fixes #6233
Screenshots
Manual Testing
How to test the changes in this Pull Request:
Testing template descriptions
Testing the search template
?s={keyword}&post_type=productand make sure the products are being displayed correctly in a grid (using the search template, instead of the default one).User Facing Testing
These are steps for user testing (where "user" is someone interacting with this change that is not editing any code).
Changelog