This repository was archived by the owner on Feb 23, 2024. It is now read-only.
Move all totals components into components package #11773
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
opr
added
status: needs review
category: extensibility
woocommercebot
requested review from
a team and
tarhi-saad
and removed request for
a team
Contributor
|
The release ZIP for this PR is accessible via: Script Dependencies ReportThere is no changed script dependency between this branch and trunk. This comment was automatically generated by the TypeScript Errors Report
assets/js/base/components/cart-checkout/totals/shipping/test/index.tsx
assets/js/base/context/hooks/payment-methods/use-payment-method-interface.ts assets/js/blocks/cart/inner-blocks/cart-order-summary-fee/block.tsx assets/js/blocks/checkout/inner-blocks/checkout-order-summary-fee/block.tsx |
Contributor
|
Size Change: +592 B (0%) Total Size: 1.59 MB
ℹ️ View Unchanged
|
14 tasks
tarhi-saad
approved these changes
Nov 17, 2023
Contributor
tarhi-saad
left a comment
tarhi-saad
left a comment
There was a problem hiding this comment.
Thank you, @opr, for working on this PR! The code looks good and the test was successful!
github-actions
bot
added
status: ready to merge
and removed
status: needs review
labels
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What
Moves the
Subtotal,TotalsFees, andTotalsItemcomponents into the@woocommerce/blocks-componentspackage.It also fixes some TS errors in some files.
Fixes #11687
Why
It doesn't make sense to have all of the components spread across three directories.
Testing Instructions
Please consider any edge cases this change may have, and also other areas of the product this may impact.
Screenshots or screencast
WooCommerce Visibility
Required:
Checklist
Required:
[type]label or a[skip-changelog]label.Conditional:
[skip-changelog]label is not present).Changelog