This repository was archived by the owner on Feb 23, 2024. It is now read-only.
Product Gallery Thumbnails: Add support for cropping #11718
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…and better control the width of the thumbnails
…p images to fit' setting
Contributor
|
The release ZIP for this PR is accessible via: Script Dependencies ReportThere is no changed script dependency between this branch and trunk. This comment was automatically generated by the TypeScript Errors Report
🎉 🎉 This PR does not introduce new TS errors. |
Contributor
|
Size Change: +8 B (0%) Total Size: 1.61 MB
ℹ️ View Unchanged
|
danieldudzic
added
block: product gallery
danieldudzic
changed the title
woocommercebot
requested review from
a team and
sunyatasattva
and removed request for
a team
13 tasks
sunyatasattva
approved these changes
Nov 21, 2023
Contributor
sunyatasattva
left a comment
sunyatasattva
left a comment
There was a problem hiding this comment.
I'm going to pre-approve not to block you, but there is a small change request 🙏
| $post_thumbnail_id = $product->get_image_id(); | ||
| $product_gallery_images = ProductGalleryUtils::get_product_gallery_images( $post_id, 'thumbnail', array(), 'wc-block-product-gallery-thumbnails__thumbnail' ); | ||
| $crop_images = $block->context['cropImages'] ?? ''; | ||
| $product_gallery_images = ProductGalleryUtils::get_product_gallery_images( $post_id, 'full', array(), 'wc-block-product-gallery-thumbnails__thumbnail', $crop_images ); |
Contributor
There was a problem hiding this comment.
Would you mind explaining why the image size went from thumbnail to full when we're dealing with thumbnails?
Contributor
Author
There was a problem hiding this comment.
The thumbnail setting for wp_get_attachment_image() outputs cropped square images with max 150px/150px dimensions.
We need to support larger images for wide layouts and preserve the aspect ratio (for the cropping disabled setting).
…s setting to false
…ocks into fix/11699-product-gallery-thumbnails-cropping
danieldudzic
deleted the
fix/11699-product-gallery-thumbnails-cropping
branch
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What
Fixes #11699
Why
This PR adds support for cropping to thumbnails.
Testing Instructions
Please consider any edge cases this change may have, and also other areas of the product this may impact.
Appearance > Editor.Templates > Single Product.Convert to Blocksif you are using the Classic Templates.Product Galleryblock.Crop images to fitenabled and disabled.Screenshots or screencast
With Cropping setting:
WooCommerce Visibility
Required:
Checklist
Required:
[type]label or a[skip-changelog]label.Conditional:
[skip-changelog]label is not present).Changelog