-
Notifications
You must be signed in to change notification settings - Fork 215
Move CheckboxControl to components package and leave alias in checkout package
#11662
Conversation
|
The release ZIP for this PR is accessible via: Script Dependencies ReportThe
This comment was automatically generated by the TypeScript Errors Report
packages/components/checkbox-control/index.tsx
|
|
Size Change: +154 B (0%) Total Size: 1.59 MB
ℹ️ View Unchanged
|
c8b939f to
5dc7f85
Compare
|
Just pointing out that you've got a neat changelog entry (that I definitely didn't copy for another PR), but you've got the |
wavvves
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM and tested out ok but this has some conflicts with trunk, can you update the branch @opr ?
Ping me when done and I'll re-test it ;)
5dc7f85 to
948c829
Compare
What
Move
CheckboxControlto components package and leave alias in checkout package.Why
Doesn't make sense to have external components in multiple locations in the codebase. An alias is left in the checkout package for backward compatibility.
Testing Instructions
Please consider any edge cases this change may have, and also other areas of the product this may impact.
Internal Developer Testing (do not include in the notes)
wc.blocksComponentswc.blocksCheckout.Screenshots or screencast
WooCommerce Visibility
Required:
Checklist
Required:
[type]label or a[skip-changelog]label.Conditional:
[skip-changelog]label is not present).Changelog