-
Notifications
You must be signed in to change notification settings - Fork 215
Move TextInput, ValidatedTextInput and ValidationInputError to the @woocommerce/blocks-components package.
#11654
Conversation
|
The release ZIP for this PR is accessible via: Script Dependencies ReportThe
This comment was automatically generated by the TypeScript Errors Report
packages/components/text-input/test/validated-text-input.tsx
packages/components/text-input/text-input.tsx |
|
Size Change: +4.28 kB (0%) Total Size: 1.54 MB
ℹ️ View Unchanged
|
mikejolley
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Changes look good but this is out of sync. Could you rebase with trunk and Ill test it properly.
This is because withInstanceId adds it, or it uses the supplied ID. It's not a required prop
|
@mikejolley rebased 👌🏼 |
mikejolley
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Tested checkout and Stripe. Seems good to go.
What
Moves
TextInput,ValidatedTextInputandValidationInputErrorto the@woocommerce/blocks-componentspackage.Please note it appears
assets/js/atomic/blocks/product-elements/add-to-cart/product-types/variable/variation-attributes/attribute-select-control.tsxis not actually used anymore as far as I could tell, but the changes were made there anyway to prevent build errors. No testing instructions for this specific path were included.Why
It doesn't make sense to have all of the components spread across three directories.
Testing Instructions
Please consider any edge cases this change may have, and also other areas of the product this may impact.
Internal WC Blocks devs only (do not include this part in the testing notes)
StripeCreditCardfunction to this:truelogged becauseValidationInputErroris a valid element.Screenshots or screencast
WooCommerce Visibility
Required:
Checklist
Required:
[type]label or a[skip-changelog]label.Conditional:
[skip-changelog]label is not present).Changelog
Dev note
We have moved the
TextInput,ValidatedTextInputandValidationInputErrorcomponents to the@woocommerce/blocks-componentspackage. Previously these were available in@woocommerce/blocks-checkout. Your code will continue to work as we have added aliases to the new location. Despite this, it is recommended that you change your code to import these components from@woocommerce/blocks-componentsas the import from the checkout package will be deprecated in the future.