This repository was archived by the owner on Feb 23, 2024. It is now read-only.
Filter By Rating: fix overlapping stars #11644
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
|
The release ZIP for this PR is accessible via: Script Dependencies ReportThere is no changed script dependency between this branch and trunk. This comment was automatically generated by the TypeScript Errors Report
🎉 🎉 This PR does not introduce new TS errors. |
Contributor
|
Size Change: -2 B (0%) Total Size: 1.54 MB
ℹ️ View Unchanged
|
gigitux
added
type: bug
gigitux
changed the title
gigitux
force-pushed
the
fix/starts-rating
branch
from
85ee0ab to
5902e76
Compare
woocommercebot
requested review from
a team and
thealexandrelara
and removed request for
a team
nielslange
approved these changes
Nov 7, 2023
Contributor
nielslange
left a comment
nielslange
left a comment
There was a problem hiding this comment.
Thanks for working on this, @gigitux. the fix works as expected. Let's ⛴️ it.
Member
|
Test fails are unrelated. Merging. |
wavvves
pushed a commit
that referenced
this pull request
Nov 7, 2023
sunyatasattva
added a commit
that referenced
this pull request
Nov 8, 2023
* Empty commit for release pull request * Enhancement/New blockified Order Confirmation on new installs with block-based themes (#11615) * Use new blockified Order Confirmation on blocks themes * Handle translations on the new blockified Order Confirmation * Update readme.txt * npm run change-versions * Filter By Rating: fix overlapping stars (#11644) * Fix Playwright E2E tests - SideEffects (#11638) * Removed span text and test * Testing notes * Empty commit for release pull request * Fix Single Product Classic Template block not showing on the front-end (#11455) In WordPress 6.4, it appears that the global `have_posts` is `false` in the context of the full site editing single product template. This breaks the Classic Template block. In this commit, we are creating a custom query using the available id instead of relying on the global query. This might be a temporary workaround as we are waiting to see if that's an issue that core is willing to fix, as it might affect backwards-compatibility for other vendors. (cherry picked from commit d9e8809) * Empty commit for release pull request * Update readme.txt * Bump versions to 11.4.5 * Add Testing Notes --------- Co-authored-by: github-actions <[email protected]> Co-authored-by: Paulo Arromba <[email protected]> Co-authored-by: Luigi Teschio <[email protected]> Co-authored-by: Lucio Giannotta <[email protected]>
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What
Fixes #11646. Fixes a regression introduced with #11468.
Why
With #11468, I introduced a UI regression when the stars are rendered inside the Filter By Rating block.
Testing Instructions
Please consider any edge cases this change may have, and also other areas of the product this may impact.
Screenshots or screencast
WooCommerce Visibility
Required:
Checklist
Required:
[type]label or a[skip-changelog]label.Conditional:
[skip-changelog]label is not present).Changelog