This repository was archived by the owner on Feb 23, 2024. It is now read-only.
Prevent Sale badge overflowing the Product Image in some product grid blocks #11556
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Aljullu
added
status: needs review
type: bug
woocommercebot
requested review from
a team and
samueljseay
and removed request for
a team
Contributor
|
The release ZIP for this PR is accessible via: TypeScript Errors Report
🎉 🎉 This PR does not introduce new TS errors. Script Dependencies ReportThere is no changed script dependency between this branch and trunk. This comment was automatically generated by the |
Contributor
|
Size Change: +19 B (0%) Total Size: 1.54 MB
ℹ️ View Unchanged
|
thealexandrelara
approved these changes
Nov 2, 2023
Contributor
thealexandrelara
left a comment
thealexandrelara
left a comment
There was a problem hiding this comment.
Great work, @Aljullu! Thank you for addressing this issue! 🚀
I tested this in multiple themes and can confirm that it solves the issue for all of them. When I initially noticed this issue, it was occurring only when I selected the "Wide Width" or "Full Width" option for the Align setting on the Products Collection/On Sale Product blocks. Do you think we should include this step in the testing instructions?
danieldudzic
approved these changes
Nov 2, 2023
Contributor
danieldudzic
left a comment
danieldudzic
left a comment
There was a problem hiding this comment.
Simple yet brilliant!
Works correctly with TT4, TT3, TT2.
Contributor
Author
|
Thanks for the reviews!
Good point, I forgot to add it. I have just updated the testing instructions to include it, thanks for mentioning! |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What
Fixes #11438.
Why
This PR updates the CSS of the product grids to prevent the Sale badge not being properly aligned with the product image.
There is some more context in #11438.
Testing Instructions
Screenshots or screencast
WooCommerce Visibility
Required:
Checklist
Required:
[type]label or a[skip-changelog]label.Conditional:
[skip-changelog]label is not present).Changelog