This repository was archived by the owner on Feb 23, 2024. It is now read-only.
Fix: Mini-Cart block shows wrong total if theres multiple installs on the same domain #11257
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
woocommercebot
requested review from
a team and
danieldudzic
and removed request for
a team
dinhtungdu
added
status: needs review
type: bug
Contributor
|
The release ZIP for this PR is accessible via: Script Dependencies ReportThe
This comment was automatically generated by the TypeScript Errors Report
assets/js/blocks/mini-cart/utils/test/data.ts
|
Contributor
|
Size Change: -3.04 kB (0%) Total Size: 1.48 MB
ℹ️ View Unchanged
|
github-actions
bot
added
status: ready to merge
and removed
status: needs review
labels
Contributor
|
@dinhtungdu this PR should have fixed this issue, right? #10307 |
5 tasks
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What
This PR fixes the issue when Mini Cart block, when is used in a sub directory, failed to fetch the cart or fetch the cart of the Woo store under the root domain.
Fixes #11168
Why
The
getMiniCartTotalsFromServer()was using a hard-coded URL to fetch the cart data, it works when the Woo store URL is the root domain but when the store uses sub directory, it doesn't. This PR fixes that issue by using@wordpress/api-fetchinstead of browser'sfetch.Testing Instructions
Please consider any edge cases this change may have, and also other areas of the product this may impact.
WooCommerce Visibility
Required:
Checklist
Required:
[type]label or a[skip-changelog]label.Conditional:
[skip-changelog]label is not present).Changelog