Ensure the Product endpoint relies on the fetch_dummy_products_to_update method for fetching dummy products to avoid code repetition and add safety checks and handle errors in case certain properties are not available.

nefeline · nefeline · commit 7c69cef9c797 · 2023-11-07T08:07:26.000+01:00
diff --git a/src/StoreApi/Routes/V1/AI/Product.php b/src/StoreApi/Routes/V1/AI/Product.php
@@ -70,36 +70,37 @@ public function get_args() {
 	 */
 	protected function get_route_post_response( \WP_REST_Request $request ) {
 		$product_updater = new ProductUpdater();
-
-		$dummy_products = $product_updater->fetch_product_ids( 'dummy' );
-
-		if ( ! is_array( $dummy_products ) ) {
-			$error = new \WP_Error( 'failed_to_fetch_dummy_products', __( 'Failed to fetch dummy products.', 'woo-gutenberg-products-block' ) );
-			return $this->error_to_response( $error );
+		$dummy_products  = $product_updater->fetch_dummy_products_to_update();
+
+		if ( empty( $dummy_products ) ) {
+			return rest_ensure_response(
+				array(
+					'ai_content_generated' => true,
+				)
+			);
 		}
 
-		// Identify dummy products that need to have their content updated.
-		$dummy_products_ids = $product_updater->fetch_product_ids( 'dummy' );
-
-		if ( ! is_array( $dummy_products_ids ) ) {
-			$error = new \WP_Error( 'failed_to_fetch_dummy_products', __( 'Failed to fetch dummy products.', 'woo-gutenberg-products-block' ) );
-			return $this->error_to_response( $error );
+		$index = $request['index'];
+		if ( ! is_numeric( $index ) ) {
+			return rest_ensure_response(
+				array(
+					'ai_content_generated' => false,
+				)
+			);
 		}
 
-		$dummy_products = array_map(
-			function ( $product ) {
-				return wc_get_product( $product->ID );
-			},
-			$dummy_products_ids
-		);
-
-		$index                = $request['index'];
-		$products_information = $request['products_information'];
+		$products_information = $request['products_information'] ?? array();
 
-		if ( $product_updater->should_update_dummy_product( $dummy_products[ $index ] ) ) {
-			$product_updater->update_product_content( $dummy_products[ $index ], $products_information );
+		if ( ! isset( $dummy_products[ $index ] ) ) {
+			return rest_ensure_response(
+				array(
+					'ai_content_generated' => false,
+				)
+			);
 		}
 
+		$product_updater->update_product_content( $dummy_products[ $index ], $products_information );
+
 		return rest_ensure_response(
 			array(
 				'ai_content_generated' => true,
