Skip to content

Conversation

@AmandaRiu
Copy link
Contributor

@AmandaRiu AmandaRiu commented Oct 21, 2020

Closes #1286 by displaying the attributes of a purchased product in the order detail view. This includes the following changes:

  • Display a comma-separated list of the selected variable product attributes if available and separate that information from the quantity section with a bullet (•). If there are no attributes to display, don't display anything including the bullet.

This FluxC PR and this FluxC PR must be merged first and this PR updated to point to that version before this PR can be reviewed.

Design

image

Screenshots

Before After

To Test

Important: Be sure to test on a store that is running the latest beta version of WooCommerce (4.7.0-rc-1) or higher, as well as a store that is running an older version to ensure the changes are backwards compatible.

  1. Create a new order that contains at least one variable item and one non-variable item.
  2. Open the order in the app and verify attributes of the variable product are displayed as designed. Also verify the product name no longer includes variation details.
  3. Verify the non-variable product is displayed properly as well (there should be no bullet (•)).

Update release notes:

  • I have considered if this change warrants user-facing release notes and have added them to RELEASE-NOTES.txt if necessary.

@AmandaRiu AmandaRiu added type: enhancement A request for an enhancement. feature: order details Related to order details. labels Oct 28, 2020
@peril-woocommerce
Copy link

You can test the changes on this Pull Request by downloading the APK here.

@AmandaRiu AmandaRiu marked this pull request as ready for review October 29, 2020 14:11
@AmandaRiu AmandaRiu requested review from 0nko, ThomazFB, anitaa1990 and nbradbury and removed request for anitaa1990 October 29, 2020 14:11
@AmandaRiu AmandaRiu added this to the 5.4 milestone Oct 29, 2020
@ThomazFB ThomazFB self-assigned this Oct 29, 2020
Copy link
Contributor

@ThomazFB ThomazFB left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking good and working just fine! Tested the feature with the correct version and did some tests with older versions to check if the behavior is retro compatible. Awesome work @AmandaRiu and @shiki! :shipit:

@ThomazFB ThomazFB merged commit 9cf847d into develop Oct 30, 2020
@ThomazFB ThomazFB deleted the issue/1286-product-variation-order-detail branch October 30, 2020 05:31
wzieba pushed a commit that referenced this pull request Jan 14, 2025
Do not alter context in `CoroutineEngine#flowWithDefaultContext`
wzieba pushed a commit that referenced this pull request Feb 3, 2025
Do not alter context in `CoroutineEngine#flowWithDefaultContext`
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

feature: order details Related to order details. type: enhancement A request for an enhancement.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Variable products with more than one attribute are displayed without the attributes

3 participants