This repository was archived by the owner on Jul 12, 2024. It is now read-only.
Correctly match payment gateways by id #7994
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
joshuatf
approved these changes
Dec 2, 2021
Contributor
joshuatf
left a comment
joshuatf
left a comment
There was a problem hiding this comment.
Thanks for the fix, @louwie17! I don't see any other areas right now that need fixes, but worth double checking with @joelclimbsthings as he may be more familiar with some of the logic around suggestion/gateway IDs on the client.
Contributor
|
Thanks for jumping on this so quickly! After a quick scan I don't see anything else that will require changes here. |
joelclimbsthings
pushed a commit
that referenced
this pull request
Dec 7, 2021
ilyasfoo
pushed a commit
that referenced
this pull request
Dec 15, 2021
ObliviousHarmony
pushed a commit
to woocommerce/woocommerce
that referenced
this pull request
Mar 18, 2022
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #7992
Fixes issue where a payment gateway id that has multiple configs differentiated by a colon in the id to still match the payment gateway correctly.
We use this for wc-pay to have different config for the us versus the rest of the world. Example of the id:
woocommerce_payments:us.No changelog necessary.
cc @joshuatf if you know of any other places that this could be a problem?
Screenshots
Detailed test instructions:
Set upbutton is now present on step 2