Skip to content
This repository was archived by the owner on Jul 12, 2024. It is now read-only.

Disable the continue btn when plugins are being installed/activated #6838

Merged
moon0326 merged 2 commits into from
Apr 22, 2021
Merged

Disable the continue btn when plugins are being installed/activated #6838

moon0326 merged 2 commits into from
Apr 22, 2021

Conversation

@moon0326
Copy link
Contributor

@moon0326 moon0326 commented Apr 21, 2021 •
edited
Loading

Fixes #6836

This PR disabled the continue button when the plugins are being installed/activated to prevent an accident click.

Detailed test instructions:

  1. In OBW fill out store details with a USA address
  2. Click Continue and select Fashion, apparel, and accessories,
  3. Click Continue, and select Physical products, and continue.
  4. The business details tab should show a Business details tab, and a Free features tab (disabled at first)
  5. Select 1-10 for the first dropdown, and No for the second, and click Continue.
  6. Make sure the "Add recommended business features to my site is ticked
  7. Click Continue, before the page redirects click Continue again
  8. Confirm no error has been recorded in your browser console.

@moon0326 moon0326 requested a review from a team April 21, 2021 00:03
@moon0326 moon0326 changed the title Disable btn when plugins are being installed Disable the continue btn when plugins are being installed/activated Apr 21, 2021
ilyasfoo
ilyasfoo approved these changes Apr 21, 2021
View reviewed changes
Copy link
Contributor

@ilyasfoo ilyasfoo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tests well, LGTM! :shipit:

@moon0326 moon0326 merged commit 16af12c into main Apr 22, 2021
@moon0326 moon0326 deleted the fix/6836-error-on-business-features-btn branch April 22, 2021 02:20
joshuatf pushed a commit that referenced this pull request Apr 28, 2021
@joshuatf
Disable the continue btn when plugins are being installed/activated (#…
27b9782 
…6838)

* Disable btn when plugins are being installed
timmyc pushed a commit that referenced this pull request May 4, 2021
Disable the continue btn when plugins are being installed/activated (#…
540b233 
…6838)

* Disable btn when plugins are being installed
@timmyc
Copy link
Contributor

timmyc commented May 4, 2021

cherry picked to release/2.3.0 in 540b233

ObliviousHarmony pushed a commit to woocommerce/woocommerce that referenced this pull request Mar 18, 2022
Disable the continue btn when plugins are being installed/activated (w…
9fe84fb 
…oocommerce/woocommerce-admin#6838)

* Disable btn when plugins are being installed
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

1 more reviewer

@ilyasfoo ilyasfoo ilyasfoo approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

focus: onboarding

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Error if click Continue twice on business features.

4 participants

@moon0326 @timmyc @ilyasfoo