-
Notifications
You must be signed in to change notification settings - Fork 143
New note: manage activity from home screen #6072
New note: manage activity from home screen #6072
Conversation
| /** | ||
| * WooCommerce Admin has been installed or updated. | ||
| */ | ||
| do_action( 'woocommerce_admin_updated' ); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The woocommerce_admin_updated action gets triggered on install or update, so I had to add some more specific actions below - woocommerce_admin_updated_existing is what is used in this particular note.
psealock
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is working well and code looks good.
So these two actions are new, yeah. What do you think about woocommerce_admin_new_install instead of woocommerce_admin_installed? This would be a fresh install right?
Yep
It would be a fresh install. I don't love |
psealock
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
woocommerce_admin_newly_installed sounds great. And 👍🏽 to keeping the tenses sane
pre-approving
e2241d0 to
b6af36f
Compare
* New note: manage activity from home screen * update readme and fix compared version * tweak the newly installed action name
Fixes #5957
This adds a new note that only triggers when updating to WooCommerce Admin 1.9.0.
Screenshots
Detailed test instructions:
UPDATE wp_options SET option_value = '1.8.0' WHERE option_name = 'woocommerce_admin_version'ManageStoreActivityFromHomeScreen.phpset the version that is checked (line 41) to1.9.0-dev(or whatever the version you are using will update to).