This repository was archived by the owner on Jul 12, 2024. It is now read-only.
Add ToS agreement copy to the WCPay setup task #5085
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
becdetat
commented
Sep 3, 2020
| if ( ! task.onClick ) { | ||
| task.onClick = () => updateQueryString( { task: task.key } ); | ||
| task.onClick = ( e ) => { | ||
| if ( e.target.nodeName === 'A' ) { |
Contributor
Author
There was a problem hiding this comment.
Note that this is never actually exercised since every task in tasks.js has an onClick handler. To test this, add the following to the end of the tasks array in tasks.js:
{
key: 'test',
title: 'Test task',
container: <Appearance/>,
completed: false,
visible: true,
additionalInfo: 'test with a <a href="https://woocommerce.com" target="_blank">link</a>',
time: '2 minutes',
},
psealock
approved these changes
Sep 3, 2020
Contributor
psealock
left a comment
psealock
left a comment
There was a problem hiding this comment.
This is testing well and code looks good. 🚢
becdetat
added a commit
that referenced
this pull request
Sep 3, 2020
Co-authored-by: Rebecca Scott <[email protected]> # Conflicts: # client/task-list/index.js # client/task-list/tasks.js
becdetat
added a commit
that referenced
this pull request
Sep 3, 2020
Contributor
Author
|
Cherry-picked into 1.5.0-rc.5 |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #5078
This adds copy re accepting the ToS to the WCPay task
Accessibility
Screenshots
Detailed test instructions:
Changelog Note:
Tweak: Add ToS agreement copy to the WCPay setup task