This repository was archived by the owner on Jul 12, 2024. It is now read-only.
Show usage modal when skipping the OBW #5061
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
psealock
reviewed
Aug 31, 2020
psealock
approved these changes
Aug 31, 2020
Contributor
psealock
left a comment
psealock
left a comment
There was a problem hiding this comment.
Cool, this is working now that we figured out JN sites. Code looks good 🚢
becdetat
added a commit
that referenced
this pull request
Sep 1, 2020
Co-authored-by: Rebecca Scott <[email protected]>
becdetat
added a commit
that referenced
this pull request
Sep 1, 2020
Co-authored-by: Rebecca Scott <[email protected]>
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #5030
This shows the usage modal (which allows opting in to tracking) when skipping the OBW.
Detailed test instructions:
woocommerce_allow_trackingoption.woocommerce_allow_trackingoption should be set to'yes'- alternatively this can be tested by starting the OBW again, the usage modal won't be displayed either when continuing or when skipping.Changelog Note:
Fix: Show usage modal when skipping the OBW