Skip to content
This repository was archived by the owner on Jul 12, 2024. It is now read-only.

Conversation

@becdetat
Copy link
Contributor

Fixes #5011

This fixes the padding on the finish, forward, and back buttons on the welcome modal. This only affects Safari, not Chrome. I've tested it in both browsers.

Screenshots

image

Detailed test instructions:

  • Either start a new site or delete the woocommerce_task_list_welcome_modal_dismissed option
  • Go to WooCommerce Home in Safari
  • The welcome modal's buttons should be aligned correctly

Changelog Note:

Fix: Padding on finish, forward, and back buttons on the welcome modal

Copy link
Contributor

@timmyc timmyc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me 👍

@becdetat becdetat merged commit b19bcf4 into main Aug 27, 2020
@becdetat becdetat deleted the fix/welcome-modal-button-padding-on-safari branch August 27, 2020 23:00
becdetat added a commit that referenced this pull request Sep 1, 2020
becdetat added a commit that referenced this pull request Sep 1, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[GlobalStep-WooCommerce Admin 1.5.0 RC1][Mac] "Next", "Previous" and "Let's Go" options are misaligned.

3 participants