Skip to content
This repository was archived by the owner on Jul 12, 2024. It is now read-only.

Use clipRule and fillRule props #4889

Merged
findingsimple merged 1 commit into from
Jul 31, 2020
Merged

Use clipRule and fillRule props #4889

findingsimple merged 1 commit into from
Jul 31, 2020

Conversation

@findingsimple
Copy link
Contributor

@findingsimple findingsimple commented Jul 30, 2020

Part of #4864

Updates use of fill-rule and clip-rule SVP path properties to be fillRule and clipRule.

Detailed test instructions:

  • Build branch
  • Go to Marketing or Coupon pages
  • Make sure Amazon, FB and Gift svgs are visible and there are no console errors

(Note I haven't been able to get the console errors mentioned in the issue to appear (in Chrome or Firefox))

@octaedro octaedro self-requested a review July 30, 2020 16:42
octaedro
octaedro approved these changes Jul 30, 2020
View reviewed changes
Copy link
Contributor

@octaedro octaedro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good job @jconroy, this tests well here and code LGTM :shipit:

@findingsimple findingsimple merged commit e838ba5 into main Jul 31, 2020
@findingsimple findingsimple deleted the fix/svg-props branch July 31, 2020 00:14
@findingsimple findingsimple mentioned this pull request Sep 1, 2020
Closed
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

1 more reviewer

@octaedro octaedro octaedro approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@findingsimple @octaedro