Skip to content
This repository was archived by the owner on Jul 12, 2024. It is now read-only.

Conversation

@jeffstieler
Copy link
Contributor

Fixes #4631. Follow up to #4683

This PR seeks to remedy one missed redirection from #4683 where tax calculations weren't enabled before redirecting to the standard rates settings page.

Detailed test instructions:

  • Enable the home screen and task list
  • Turn off tax calculations for the store (WooCommerce > Settings > General - uncheck "Enable tax rates and calculations")
  • Ensure the "install" step will be shown for the Tax setup task (be in a TaxJar supported country)
  • Click "Set up tax rates manually" on the install step
  • Verify that you are redirected to the Tax settings tab

@jeffstieler jeffstieler requested a review from a team July 29, 2020 17:07
Copy link
Contributor

@joshuatf joshuatf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the catch and fix here! Working as described 🚢

@jeffstieler
Copy link
Contributor Author

jeffstieler commented Jul 30, 2020

Should this get 🍒 picked to 1.4.0? @timmyc

@jeffstieler jeffstieler merged commit 8840c9b into main Jul 30, 2020
@jeffstieler jeffstieler deleted the fix/4631-tax-step-skip-jp-install branch July 30, 2020 16:04
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

focus: onboarding type: bug The issue is a confirmed bug.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Task List - Tax task: redirect to settings after enable automated taxes

3 participants