Activity Panel - event tracking improved #4861
Conversation
octaedro
added
status: in progress
focus: activity panel
jeffstieler
left a comment
jeffstieler
left a comment
There was a problem hiding this comment.
This tested well and the code looks good. Curious - why didn't the "learn more" button in the empty Orders panel get any tracking?
| <Link | ||
| href={ customerUrl } | ||
| onClick={ () => | ||
| this.recordOrderEvent( 'customer_name' ) |
There was a problem hiding this comment.
I know this is what the issue requested, but it seems like it should be prefixed with order_ to avoid ambiguity.
|
|
||
| updateProductStock( product, quantity ); | ||
| this.recordStockEvent( 'save', { | ||
| quantity, |
There was a problem hiding this comment.
Maybe more of a question for @pmcpinto - what is the value/use of knowing the stock quantity being modified? Without any context it seems rather useless.. and to be clear I'm not advocating for adding more data to this event.
jeffstieler
added
needs: author feedback
I missed that one 😞 It would be good to include it. @octaedro
The main goal is to understand if the feature is being used and if the job is being completed (open the stock panel > click update stock > save the new stock). |
No problem @pmcpinto, I will add it. Also, I wanted to ask you if it is ok to add what Jeff suggested about adding a prefix |
Sure, go ahead. Thanks! |
This commit adds event recording to `ProductStockCard`
This commit adds event recording to the orders panel
This commit adds event recording to the reviews panel
|
As the new event recording was added, I did a rebase and merged this PR. |
octaedro
removed
the
needs: author feedback
Fixes #4432
This PR adds event recording to the
Orders,Stock, andReviewspanels.Accessibility
prefers-reduced-motionDetailed test instructions:
Orders panel:
Event name: wcadmin_activity_panel_orders_begin_fulfillment
Event prop: NA
Description: when the user clicks in the "Begin fulfillment" button
Event name: wcadmin_activity_panel_orders_manage
Event prop: NA
Description: when the user clicks in the "Manage all orders" button
Event name: wcadmin_activity_panel_order_number
Event prop: NA
Description: when the user clicks in the order number link
Event name: wcadmin_activity_panel_customer_name
Event prop: NA
Description: when the user clicks in the customer name link
Stock:
Event name: wcadmin_activity_panel_stock_product_name
Event prop: NA
Description: when the user clicks in the product name link
Event name: wcadmin_activity_panel_stock_update_stock
Event prop: NA
Description: when the user clicks in the "Update stock" button
Event name: wcadmin_activity_panel_stock_save
Event prop:
quantity, the number of products added to the inventoryDescription: when the user clicks in the "Save" button
Event name: wcadmin_activity_panel_stock_cancel
Event prop: NA
Description: when the user clicks in the "Cancel" button
Reviews:
Event name: wcadmin_activity_panel_reviews_learn_more
Event prop: NA
Description: when the user clicks in the "Learn More" button in the empty state
Event name: wcadmin_activity_panel_reviews_view_reviews
Event prop: NA
Description: when the user clicks in the "View reviews" button in the empty state
Event name: wcadmin_activity_panel_reviews_product
Event prop: NA
Description: when the user clicks in the product name
Event name: wcadmin_activity_panel_reviews_customer
Event prop: NA
Description: when the user clicks in the customer name
Changelog Note:
Dev: Added event recording to
Orders,Stock, andReviewspanels.