New notification: Don't forget to test your checkout #4805

octaedro · 2020-07-14T15:55:18Z

This PR adds a note to remind the user to test the checkout process.
This note should be triggered when the user has a payment method AND adds or imports products.

Segmentation:
New users with setup_client: false on wcadmin_storeprofiler_store_details_continue
Timing:
"After triggering:
wcadmin_product_add_publish or wcadmin_product_import_complete
AND
task_name: payments on wcadmin_tasklist_task_completed
Cadence: Once

Screenshots

Detailed test instructions:

Execute the cron. To do it you can install this plugin and go to /wp-admin/tools.php?page=crontrol_admin_manage_pageand press wc_admin_daily.
Add a new product.
At the end of the process, the note should be visible.
Remove the note and the variable: wc_admin_note_test_checkout_product_added from the database with a sentence like this:

DELETE FROM `wp_options` WHERE `wp_options`.`option_name` = 'wc_admin_note_test_checkout_product_added';
DELETE FROM `wp_wc_admin_notes` WHERE `wp_wc_admin_notes`.`name` = 'wc-admin-test-checkout';

Import products.
At the end of the process, the note should be visible.
Verify the call to action button in the note opens the store frontend in a new tab

Changelog Note:

Dev: New notification: Don't forget to test your checkout

jeffstieler · 2020-07-16T13:15:45Z

src/Notes/WC_Admin_Notes_Test_Checkout.php

+		// Make sure a product was published or imported.
+		$product_added = get_option(
+			self::PRODUCT_ADDED_OPTION_NAME
+		);


Rather than hook into the importer and post status transition hooks, what do you think about checking the status of the products step in the task list instead? Seems like this could be simpler if we were just checking for the products and payments steps to be complete.

Really like this idea Jeff!

Hi @jeffstieler, thanks for your review.
Diving a little bit into that part of the code, I realized that the check (that later will be used to set the products state in the task list) is calculated in the API side in the method check_task_completion and it's asking for products with state published or draft. From what I understand, this could be a problem since we need to show the note after the product publication, but the list item could be set as completed without a published product.
Please correct me if I misunderstood your suggestion or I'm forgetting something.

Hmm.. looks like that wasn't the original intention and was updated later: #2667 (comment)

Perhaps we should look at only marking the step complete if there are published products? cc: @timmyc

Yeah I concur there, but cc @pmcpinto to verify for sure. The product step right now will get marked as done even when a product is in the draft state. But I definitely like tying this note to that step being completed because it will eliminate this note possibly being shown on an established site.

Thank you @jeffstieler and @timmyc, I removed the verification of the products with state draft in the commit 14d5df2 and it looks like everything is working well.

I was thinking about when this note should be shown. If the user doesn't set a payment method when the Add my products task list is completed, the note won't be shown. Also, we don't save a timestamp when we update the products' task list, which means that we don't know when we completed this task list item.

The note reminds the user Don't forget to test your checkout, so it looks like we should show the note if the user adds their first product and has the other conditions we need. For instance, a user could have everything set but no products for a month. Should we show the note if they suddenly add a product?

If the answer is yes, I think that we should verify the published date of the first product, and if it's within the last 30 (or 15, or 10) minutes and fulfills the other conditions, I would trigger the note.
Does this make sense?

jeffstieler · 2020-07-16T13:20:57Z

src/Notes/WC_Admin_Notes_Test_Checkout.php

+		$note->set_type( WC_Admin_Note::E_WC_ADMIN_NOTE_INFORMATIONAL );
+		$note->set_name( self::NOTE_NAME );
+		$note->set_source( 'woocommerce-admin' );
+		$note->add_action( 'test-checkout', __( 'Test checkout', 'woocommerce-admin' ), site_url() );


If we use wc_get_page_permalink( 'shop' ) here it will direct them to the shop, and automatically falls back to the site url.

Good idea! I replaced the method in the commit 58c866a

pmcpinto · 2020-07-17T09:17:08Z

The product step right now will get marked as done even when a product is in the draft state. But I definitely like tying this note to that step being completed because it will eliminate this note possibly being shown on an established site.

Can we use the store creation date to avoid show this to existing stores? We have a good amount of new users that add a product without going through the task list step. Is this step being marked as completed even if they add a product without passing by this task?

octaedro · 2020-07-20T16:37:51Z

Hi @pmcpinto,

Can we use the store creation date to avoid show this to existing stores?

Looking at the notification message I was thinking that maybe we could do the verification using the date of the first published product to show this note.
I'm thinking about the case where a user could have everything set in their store but no products for a month. After adding their first product we can incentivize them to take a look at their checkout process.
Maybe we can check if the user added a product in the last half hour to show this note.
Does this make sense?

We have a good amount of new users that add a product without going through the task list step. Is this step being marked as completed even if they add a product without passing by this task?

Yes, we mark the step as complete even if the user adds a product without passing by this task.

pmcpinto · 2020-07-20T16:55:48Z

Does this make sense?

Yep, sounds good to me. Thanks for the suggestion!

octaedro · 2020-07-21T13:16:26Z

According to Pedro's answer I added the time validation (30 minutes) to the first published product in the commit 04faa14.
At the same time, now we're checking the status of the products step in the task list (as @jeffstieler suggested) and I added another hook to do the same with the payment methods step.
Also, I did a rebase since there were a few conflicts between branches.
I think that now this PR is ready for another look.

src/Notes/WC_Admin_Notes_Test_Checkout.php

jeffstieler · 2020-07-21T16:22:40Z

src/Notes/WC_Admin_Notes_Test_Checkout.php

+		}
+
+		$oldest_product_timestamp = $products[0]->get_date_created()->getTimestamp();
+		$half_hour_in_seconds     = 0.5 * HOUR_IN_SECONDS;


Nitpick: 30 * MINUTE_IN_SECONDS would avoid float and int comparison.

Good idea! I modified it in the commit 8d31053

jeffstieler · 2020-07-21T16:47:07Z

src/Notes/WC_Admin_Notes_Test_Checkout.php

+			return;
+		}
+
+		$content = __( 'Make sure that your checkout is working properly before your launch your store. Go through your checkout process in its entirety: from adding a product to your cart, choosing a shipping location, and making a payment.', 'woocommerce-admin' );


Typo: "before your launch your store" -> "before you launch your store".

Nice catch! I changed it in the commit 85a0054

jeffstieler

This tested well - just need to fix a typo and make some minor code tweaks. Pre-approving.

This commit adds a note to test the checkout process # Conflicts: # src/Events.php # src/FeaturePlugin.php

…tion" This commit modifies the code to not set the products task list item as done when they have state draft.

This commit adds a product published date control to the note

octaedro · 2020-07-22T18:22:54Z

As all the fixes have been addressed I'm going to merge this PR.

octaedro added [Status] Needs Review focus: inbox Issues related to inbox notifications labels Jul 14, 2020

octaedro requested a review from a team July 14, 2020 15:55

octaedro self-assigned this Jul 14, 2020

jeffstieler reviewed Jul 16, 2020

View reviewed changes

jeffstieler added needs: author feedback The issue/PR needs a response from any of the parties involved in the issue. and removed [Status] Needs Review labels Jul 16, 2020

octaedro force-pushed the add/4213 branch from e98e2bc to 1eb7a0f Compare July 20, 2020 17:36

octaedro added [Status] Needs Review and removed needs: author feedback The issue/PR needs a response from any of the parties involved in the issue. labels Jul 21, 2020

jeffstieler reviewed Jul 21, 2020

View reviewed changes

src/Notes/WC_Admin_Notes_Test_Checkout.php Show resolved Hide resolved

jeffstieler reviewed Jul 21, 2020

View reviewed changes

jeffstieler approved these changes Jul 21, 2020

View reviewed changes

jeffstieler added needs: author feedback The issue/PR needs a response from any of the parties involved in the issue. [Status] Ready to Merge and removed [Status] Needs Review labels Jul 21, 2020

octaedro added 4 commits July 22, 2020 14:27

Added Test Checkout note

7679159

This commit adds a note to test the checkout process # Conflicts: # src/Events.php # src/FeaturePlugin.php

Replaced method "site_url" with "wc_get_page_permalink"

7db32fb

Removed products with state draft verifcation from "check_task_comple…

9bcb1c5

…tion" This commit modifies the code to not set the products task list item as done when they have state draft.

Added published date control

04faa14

This commit adds a product published date control to the note

octaedro force-pushed the add/4213 branch from ba81241 to 31910be Compare July 22, 2020 17:31

octaedro added 2 commits July 22, 2020 15:06

Half-hour calculation changed

8d31053

Typo error corrected

85a0054

octaedro force-pushed the add/4213 branch from a99968f to 85a0054 Compare July 22, 2020 18:07

octaedro removed the needs: author feedback The issue/PR needs a response from any of the parties involved in the issue. label Jul 22, 2020

octaedro merged commit 4b7cbb8 into main Jul 22, 2020

octaedro deleted the add/4213 branch July 22, 2020 18:24

tarhi-saad mentioned this pull request Oct 18, 2023

Remove the TestCheckout note woocommerce/woocommerce#40851

Merged

11 tasks

New notification: Don't forget to test your checkout #4805

New notification: Don't forget to test your checkout #4805

Uh oh!

Conversation

octaedro commented Jul 14, 2020

Screenshots

Detailed test instructions:

Changelog Note:

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

octaedro Jul 16, 2020 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

pmcpinto commented Jul 17, 2020

Uh oh!

octaedro commented Jul 20, 2020 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

pmcpinto commented Jul 20, 2020

Uh oh!

octaedro commented Jul 21, 2020 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

jeffstieler left a comment

Choose a reason for hiding this comment

Uh oh!

octaedro commented Jul 22, 2020

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

octaedro Jul 16, 2020 •

edited

Loading

octaedro commented Jul 20, 2020 •

edited

Loading

octaedro commented Jul 21, 2020 •

edited

Loading