Claude finished @kmanijak's task —— View job

BC Review Complete

Summary: Overall Risk Low

This PR adds an empty attributes: {} object to a single block.json file as a temporary workaround for a Gutenberg regression (GB #73135) where blocks with supports.color but no attributes definition cause the post editor to crash with a blank page.

The change is backwards compatible and low risk. Adding an empty attributes object does not alter block behavior, data storage, or API contracts. It's purely a schema addition that satisfies Gutenberg's internal validation requirements.

BC Analysis

What Changed

File: plugins/woocommerce/client/blocks/assets/js/blocks/add-to-cart-with-options/grouped-product-selector/product-item-label/block.json:11

+ "attributes": {},

Before: Block had no attributes key defined
After: Block has empty attributes: {} object

BC Impact Assessment

✅ No Breaking Changes Detected

Why this is BC-safe:

1. Block Attributes Schema: Adding an empty attributes object is semantically equivalent to having no attributes. WordPress/Gutenberg treats both cases identically when registering blocks - blocks without attributes simply have no configurable properties.

2. Data Storage: No existing block instances in the database are affected. Blocks without attributes don't store attribute data, and this change doesn't introduce any new required attributes.

3. Block Registration: The block name (woocommerce/add-to-cart-with-options-grouped-product-item-label) remains unchanged. All other metadata (supports, ancestor, apiVersion) is preserved.

4. Rendering: No changes to display logic or template. The block continues to render using the same color/typography/spacing supports it had before.

5. Extension Compatibility: Third-party extensions filtering or extending this block won't break - adding an empty object doesn't invalidate existing attribute filters or modifications.

Potential Risks (None Identified):

• ❌ No public API signature changes
• ❌ No hook additions/removals
• ❌ No template modifications
• ❌ No REST endpoint changes
• ❌ No database schema changes
• ❌ No JavaScript API changes

Additional Blocks at Risk

During analysis, I identified two other blocks with the same pattern (color support + no attributes) that may also crash the editor with Gutenberg nightly:

1. plugins/woocommerce/client/blocks/assets/js/blocks/add-to-cart-with-options/variation-description/block.json

   • Has supports.color.gradients and supports.color.link
   • Missing attributes key entirely

2. plugins/woocommerce/client/blocks/assets/js/blocks/mini-cart/mini-cart-contents/inner-blocks/mini-cart-title-items-counter-block/block.json

   • Has supports.color.text and supports.color.background
   • Missing attributes key entirely

Recommendation: Consider applying the same fix to these blocks in a follow-up PR once this workaround is validated, or wait for the upstream Gutenberg fix.

Testing Focus

Primary Regression Areas:

1. Grouped Product Selector (directly affected)

   • Add grouped product to page/post in block editor
   • Verify editor doesn't crash (no blank page)
   • Verify color/typography controls still work in block settings
   • Verify product item label renders correctly on frontend

2. Block Persistence

   • Create/edit page with this block, save, reload editor
   • Verify no block validation errors or recovery prompts

3. Extension Compatibility

   • Test with extensions that modify grouped product blocks (if any)
   • Verify no console errors related to attribute access

Test Steps:

1. ✅ CI with GB nightly passes (per PR description)
2. Create new page with grouped product
3. Customize item label colors/typography
4. Save and reload editor
5. Verify no blank screen, no console errors

Changelog Review

File: plugins/woocommerce/changelog/fix-e2e-with-gb-regresssion

Significance: patch
Type: tweak
Comment: Add empty attributes to the block.json to avoid editor crash. Temporary measure before there's a fix in GB

✅ Changelog is appropriate

• Correct significance (patch - minimal change, no API impact)
• Correct type (tweak - minor adjustment)
• Comment accurately describes temporary workaround nature

Confidence: 95%

Justification: This is a schema-only addition with no behavioral impact. The change pattern (empty attributes object) is well-understood in WordPress block development and widely used across core blocks. Risk is limited to potential edge cases in block serialization/deserialization, which are covered by existing WooCommerce block tests and GB nightly CI validation.

The 5% uncertainty accounts for:

• Untested interaction with custom block extensions
• Potential future GB behavior changes around empty attributes
• Temporary workaround may need reverting after upstream fix

Ecosystem Impact

Payment Gateways: ❌ No impact (non-checkout block)
Subscriptions/Bookings: ❌ No impact (product display only)
Themes: ❌ No impact (no template changes)
Custom Checkout: ❌ No impact (not checkout-related)

Final Recommendation

✅ Approve for merge

This is a safe, minimal workaround for a legitimate Gutenberg regression. The change follows best practices and includes appropriate changelog entry. No deprecation needed as this adds functionality rather than removing it.

Post-merge action: Monitor GB issue #73135 for upstream fix, then consider reverting this workaround or keeping it for older GB version compatibility.

Testing Guidelines

Hi @adimoldovan @dinhtungdu ,

Apart from reviewing the code changes, please make sure to review the testing instructions (Guide) and verify that relevant tests (E2E, Unit, Integration, etc.) have been added or updated as needed.

Reminder: PR reviewers are required to document testing performed. This includes:

• 🖼️ Screenshots or screen recordings.
• 📝 List of functionality tested / steps followed.
• 🌐 Site details (environment attributes such as hosting type, plugins, theme, store size, store age, and relevant settings).
• 🔍 Any analysis performed, such as assessing potential impacts on environment attributes and other plugins, conducting performance profiling, or using LLM/AI-based analysis.

⚠️ Within the testing details you provide, please ensure that no sensitive information (such as API keys, passwords, user data, etc.) is included in this public issue.

Pre-merge checks and finishing touches

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

_{Comment @coderabbitai help to get the list of available commands and usage tips.}

Test using WordPress Playground

The changes in this pull request can be previewed and tested using a WordPress Playground instance.
WordPress Playground is an experimental project that creates a full WordPress instance entirely within the browser.

Test this pull request with WordPress Playground.

Note that this URL is valid for 30 days from when this comment was last updated. You can update it by closing/reopening the PR or pushing a new commit.

I think this is more of a core issue, and doing this will just hide it under the rug. If we do it, let's make sure to revert it afterwards.

I think this is more of a core issue, and doing this will just hide it under the rug. If we do it, let's make sure to revert it afterwards.

Yeah, we'll do! While I agree about hiding under the rug, we often noticed the opposite effect when keeping the error failing, would cover other issues happening at the same time because we get used to failing tests. So I'll keep it and will remove later on!