Turn Cost of Goods Sold into a non-experimental feature #60847

Konamiman · 2025-09-10T11:47:03Z

Changes proposed in this Pull Request:

Until now the Cost of Goods Sold feature was considered experimental. That's no longer the case, so this pull request moves the feature from the "Experimental" section to the regular features section in the features settings page:

How to test the changes in this Pull Request:

Open WooCommerce - Settings - Advanced - Features and verify that Cost of Goods Sold is not in the "Experimental" section, as in the screenshot above.
Activate the feature and run the following in the shell, you should get 1:

wp eval 'echo wc_get_container()->get(Automattic\WooCommerce\Internal\CostOfGoodsSold\CostOfGoodsSoldController::class)->feature_is_enabled();'

Changelog entry

Automatically create a changelog entry from the details below.

This Pull Request does not require a changelog entry. (Comment required below)

Changelog Entry Details

Significance

Patch
Minor
Major

Type

Fix - Fixes an existing bug
Add - Adds functionality
Update - Update existing functionality
Dev - Development related task
Tweak - A minor adjustment to the codebase
Performance - Address performance issues
Enhancement - Improvement to existing functionality

Message

Changelog Entry Comment

Comment

github-actions · 2025-09-10T11:47:30Z

Testing Guidelines

Hi @prettyboymp ,

Apart from reviewing the code changes, please make sure to review the testing instructions (Guide) and verify that relevant tests (E2E, Unit, Integration, etc.) have been added or updated as needed.

Reminder: PR reviewers are required to document testing performed. This includes:

🖼️ Screenshots or screen recordings.
📝 List of functionality tested / steps followed.
🌐 Site details (environment attributes such as hosting type, plugins, theme, store size, store age, and relevant settings).
🔍 Any analysis performed, such as assessing potential impacts on environment attributes and other plugins, conducting performance profiling, or using LLM/AI-based analysis.

⚠️ Within the testing details you provide, please ensure that no sensitive information (such as API keys, passwords, user data, etc.) is included in this public issue.

coderabbitai · 2025-09-10T11:49:33Z

📝 Walkthrough

Walkthrough

The change marks the Cost of Goods Sold feature as non-experimental by setting its is_experimental flag to false and adds a corresponding changelog entry indicating a minor update.

Changes

Cohort / File(s)	Summary
COGS feature flag update `plugins/woocommerce/src/Internal/CostOfGoodsSold/CostOfGoodsSoldController.php`	Set `is_experimental` from `true` to `false` in `add_feature_definition` for `cost_of_goods_sold`.
Changelog entry `plugins/woocommerce/changelog/pr-60847`	Added changelog noting minor update: COGS turned into a non-experimental (stable) feature.

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~10 minutes

Pre-merge checks (3 passed)

✅ Passed checks (3 passed)

Check name	Status	Explanation
Title Check	✅ Passed	The pull request title concisely and accurately summarizes the primary change of the feature moving out of experimental status by stating “Turn Cost of Goods Sold into a non-experimental feature,” making it clear and specific for teammates reviewing the history.
Description Check	✅ Passed	The description directly relates to the change by explaining that the Cost of Goods Sold feature is no longer experimental, detailing the UI update and CLI verification steps, and including a screenshot that matches the changeset.
Docstring Coverage	✅ Passed	Docstring coverage is 100.00% which is sufficient. The required threshold is 80.00%.

Tip

👮 Agentic pre-merge checks are now available in preview!

Pro plan users can now enable pre-merge checks in their settings to enforce checklists before merging PRs.

Built-in checks – Quickly apply ready-made checks to enforce title conventions, require pull request descriptions that follow templates, validate linked issues for compliance, and more.
Custom agentic checks – Define your own rules using CodeRabbit’s advanced agentic capabilities to enforce organization-specific policies and workflows. For example, you can instruct CodeRabbit’s agent to verify that API documentation is updated whenever API schema files are modified in a PR. Note: Upto 5 custom checks are currently allowed during the preview period. Pricing for this feature will be announced in a few weeks.

Please see the documentation for more information.

Example:

reviews:
  pre_merge_checks:
    custom_checks:
      - name: "Undocumented Breaking Changes"
        mode: "warning"
        instructions: |
          Pass/fail criteria: All breaking changes to public APIs, CLI flags, environment variables, configuration keys, database schemas, or HTTP/GraphQL endpoints must be documented in the "Breaking Change" section of the PR description and in CHANGELOG.md. Exclude purely internal or private changes (e.g., code not exported from package entry points or explicitly marked as internal).

Please share your feedback with us on this Discord post.

📜 Recent review details

Configuration used: Path: .coderabbit.yml

Review profile: CHILL

Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 9ef7c96 and 6a25bcc.

📒 Files selected for processing (2)

plugins/woocommerce/changelog/pr-60847 (1 hunks)
plugins/woocommerce/src/Internal/CostOfGoodsSold/CostOfGoodsSoldController.php (1 hunks)

🧰 Additional context used

📓 Path-based instructions (2)

**/*.{php,js,jsx,ts,tsx}

📄 CodeRabbit inference engine (.cursor/rules/code-quality.mdc)

**/*.{php,js,jsx,ts,tsx}: Guard against unexpected inputs
Sanitize and validate any potentially dangerous inputs
Ensure code is backwards compatible
Write code that is readable and intuitive
Ensure code has unit or E2E tests where applicable

Files:

plugins/woocommerce/src/Internal/CostOfGoodsSold/CostOfGoodsSoldController.php

**/*.{php,js,ts,jsx,tsx}

⚙️ CodeRabbit configuration file

**/*.{php,js,ts,jsx,tsx}: Don't trust that extension developers will follow the best practices, make sure the code:

Guards against unexpected inputs.

Sanitizes and validates any potentially dangerous inputs.

Is backwards compatible.

Is readable and intuitive.

Has unit or E2E tests where applicable.

Files:

plugins/woocommerce/src/Internal/CostOfGoodsSold/CostOfGoodsSoldController.php

🧠 Learnings (2)

📓 Common learnings

Learnt from: samueljseay
PR: woocommerce/woocommerce#59051
File: plugins/woocommerce/client/blocks/assets/js/blocks/mini-cart/mini-cart-contents/inner-blocks/mini-cart-footer-block/index.tsx:66-70
Timestamp: 2025-06-23T05:47:52.696Z
Learning: For WooCommerce mini-cart blocks in plugins/woocommerce/client/blocks/assets/js/blocks/mini-cart/, the standardized conditional pattern for experimental features should be `if ( isExperimentalMiniCartEnabled() ) { blockSettings.save = () => <InnerBlocks.Content />; }` - defaulting to the traditional Save component and only overriding when the experimental feature is enabled.

📚 Learning: 2025-07-15T15:39:21.856Z

Learnt from: jorgeatorres
PR: woocommerce/woocommerce#59675
File: .github/workflows/release-bump-as-requirement.yml:48-65
Timestamp: 2025-07-15T15:39:21.856Z
Learning: In WooCommerce core repository, changelog entries for all PRs live in `plugins/woocommerce/changelog/` directory and are processed during releases, not at the repository root level.

Applied to files:

plugins/woocommerce/changelog/pr-60847

⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (13)

GitHub Check: Core API tests - @woocommerce/plugin-woocommerce [api]
GitHub Check: Core e2e tests 6/6 - @woocommerce/plugin-woocommerce [e2e]
GitHub Check: Metrics - @woocommerce/plugin-woocommerce [performance]
GitHub Check: Core e2e tests 1/6 - @woocommerce/plugin-woocommerce [e2e]
GitHub Check: PHP: 7.4 WP: latest - 1 [WP 6.7.3] 1/2 - @woocommerce/plugin-woocommerce [unit:php]
GitHub Check: Core e2e tests 2/6 - @woocommerce/plugin-woocommerce [e2e]
GitHub Check: Core e2e tests 4/6 - @woocommerce/plugin-woocommerce [e2e]
GitHub Check: Core e2e tests 5/6 - @woocommerce/plugin-woocommerce [e2e]
GitHub Check: Core e2e tests 3/6 - @woocommerce/plugin-woocommerce [e2e]
GitHub Check: PHP: 7.4 WP: latest - 1 [WP 6.7.3] 2/2 - @woocommerce/plugin-woocommerce [unit:php]
GitHub Check: PHP: 8.4 WP: latest [WP latest] 2/2 - @woocommerce/plugin-woocommerce [unit:php]
GitHub Check: PHP: 8.4 WP: latest [WP latest] 1/2 - @woocommerce/plugin-woocommerce [unit:php]
GitHub Check: build

🔇 Additional comments (2)

plugins/woocommerce/src/Internal/CostOfGoodsSold/CostOfGoodsSoldController.php (1)

55-59: COGS feature promotion complete—no experimental references found
Search for “Experimental” tied to Cost of Goods Sold in plugin code and tests returned no matches; no E2E/admin test or UI selector updates required.

plugins/woocommerce/changelog/pr-60847 (1)

1-4: No Comment: field needed. Recent changelog entries use only Significance: and Type: followed by the message body on its own line—your entry matches this pattern and can be left unchanged.

✨ Finishing Touches

📝 Generate Docstrings

🧪 Generate unit tests

Create PR with unit tests
Post copyable unit tests in a comment
Commit unit tests in branch cogs/make-not-experimental

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

_{Comment @coderabbitai help to get the list of available commands and usage tips.}

github-actions · 2025-09-10T11:55:24Z

Test using WordPress Playground

The changes in this pull request can be previewed and tested using a WordPress Playground instance.
WordPress Playground is an experimental project that creates a full WordPress instance entirely within the browser.

Test this pull request with WordPress Playground.

Note that this URL is valid for 30 days from when this comment was last updated. You can update it by closing/reopening the PR or pushing a new commit.

prettyboymp

All looks good.

Turn COGS into a non-experimental feature

b05a985

Konamiman self-assigned this Sep 10, 2025

github-actions bot added the plugin: woocommerce Issues related to the WooCommerce Core plugin. label Sep 10, 2025

woocommercebot requested review from a team and prettyboymp and removed request for a team September 10, 2025 11:47

Add changelog file

6a25bcc

prettyboymp approved these changes Sep 11, 2025

View reviewed changes

Konamiman mentioned this pull request Sep 15, 2025

Add filters for customizing COGS total and refunded COGS output in admin order screen #60361

Merged

12 tasks

Konamiman merged commit 737e23f into trunk Sep 15, 2025
26 checks passed

Konamiman deleted the cogs/make-not-experimental branch September 15, 2025 15:20

github-actions bot added this to the 10.3.0 milestone Sep 15, 2025

coderabbitai bot mentioned this pull request Sep 15, 2025

[Migrator]: Add COGS support even if the feature is disabled #60862

Merged

12 tasks

coderabbitai bot mentioned this pull request Sep 23, 2025

Various FeaturesController enhancements #60809

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Turn Cost of Goods Sold into a non-experimental feature #60847

Turn Cost of Goods Sold into a non-experimental feature #60847

Uh oh!

Konamiman commented Sep 10, 2025

Uh oh!

github-actions bot commented Sep 10, 2025 •

edited

Loading

Uh oh!

coderabbitai bot commented Sep 10, 2025 •

edited

Loading

Walkthrough

Changes

Estimated code review effort

Uh oh!

github-actions bot commented Sep 10, 2025

Uh oh!

prettyboymp left a comment

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

Turn Cost of Goods Sold into a non-experimental feature #60847

Turn Cost of Goods Sold into a non-experimental feature #60847

Uh oh!

Conversation

Konamiman commented Sep 10, 2025

Changes proposed in this Pull Request:

How to test the changes in this Pull Request:

Changelog entry

Significance

Type

Message

Comment

Uh oh!

github-actions bot commented Sep 10, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Testing Guidelines

Uh oh!

coderabbitai bot commented Sep 10, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Walkthrough

Changes

Estimated code review effort

Pre-merge checks (3 passed)

Uh oh!

github-actions bot commented Sep 10, 2025

Test using WordPress Playground

Uh oh!

prettyboymp left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

github-actions bot commented Sep 10, 2025 •

edited

Loading

coderabbitai bot commented Sep 10, 2025 •

edited

Loading