plugins/woocommerce/tests/php/src/Internal/CLI/Migrator/Platforms/Shopify/ShopifyMapperTest.php:491

• The selective field processing test only verifies that excluded fields are not present in the result, but doesn't test that the fields_to_process array actually controls which processing logic is executed. Consider adding assertions that verify the mapper skips expensive operations when fields are not requested.

	public function test_selective_field_processing() {

plugins/woocommerce/src/Internal/CLI/Migrator/Platforms/Shopify/ShopifyMapper.php (5)

116-117: Use numeric comparison for prices

String comparison of prices can lead to incorrect results (e.g., '9.99' > '10.00' evaluates to true).

-				if ( $variant_node->compareAtPrice && $variant_node->compareAtPrice > $variant_node->price ) {
+				if ( $variant_node->compareAtPrice && (float) $variant_node->compareAtPrice > (float) $variant_node->price ) {

---

132-132: Add null check for inventoryItem

The code verifies that 'inventoryItem' property exists but doesn't check if it's null before accessing its 'tracked' property.

-				$manage_stock              = property_exists( $variant_node, 'inventoryItem' ) && $variant_node->inventoryItem->tracked;
+				$manage_stock              = property_exists( $variant_node, 'inventoryItem' ) && $variant_node->inventoryItem && $variant_node->inventoryItem->tracked;

---

227-227: Use numeric comparison for prices (duplicate logic)

Same string comparison issue as line 116. Consider extracting this into a helper method to avoid duplication.

-					if ( $variant_node->compareAtPrice && (float) $variant_node->compareAtPrice > (float) $variant_node->price ) {
+					if ( $variant_node->compareAtPrice && (float) $variant_node->compareAtPrice > (float) $variant_node->price ) {

Wait, I see the cast is already there. Let me re-examine...

---

243-243: Add null check for inventoryItem

Same null pointer issue as line 132. The code doesn't verify if inventoryItem is null.

-					$manage_stock                     = property_exists( $variant_node, 'inventoryItem' ) && $variant_node->inventoryItem->tracked;
+					$manage_stock                     = property_exists( $variant_node, 'inventoryItem' ) && $variant_node->inventoryItem && $variant_node->inventoryItem->tracked;

---

460-468: Define arrays as class constants for better performance

The unit mapping and conversion factors arrays are recreated on every method call, which impacts performance during bulk imports.

Add these as class constants:

+	/**
+	 * Unit mapping from Shopify to internal format.
+	 */
+	private const UNIT_MAP = array(
+		'GRAMS'     => 'g',
+		'KILOGRAMS' => 'kg',
+		'POUNDS'    => 'lb',
+		'OUNCES'    => 'oz',
+	);
+
+	/**
+	 * Weight conversion factors.
+	 */
+	private const CONVERSION_FACTORS = array(
+		'kg' => array(
+			'kg' => 1,
+			'g'  => 1000,
+			'lb' => 2.20462,
+			'oz' => 35.274,
+		),
+		'g'  => array(
+			'kg' => 0.001,
+			'g'  => 1,
+			'lb' => 0.00220462,
+			'oz' => 0.035274,
+		),
+		'lb' => array(
+			'kg' => 0.453592,
+			'g'  => 453.592,
+			'lb' => 1,
+			'oz' => 16,
+		),
+		'oz' => array(
+			'kg' => 0.0283495,
+			'g'  => 28.3495,
+			'lb' => 0.0625,
+			'oz' => 1,
+		),
+	);

 	private function get_converted_weight( $weight, $weight_unit ): ?float {
 		if ( null === $weight || null === $weight_unit || (float) $weight <= 0 ) {
 			return null;
 		}

-		$unit_map = array(
-			'GRAMS'     => 'g',
-			'KILOGRAMS' => 'kg',
-			'POUNDS'    => 'lb',
-			'OUNCES'    => 'oz',
-		);
-
-		$shopify_unit_key = $unit_map[ $weight_unit ] ?? null;
+		$shopify_unit_key = self::UNIT_MAP[ $weight_unit ] ?? null;

And update the conversion logic:

-		$conversion_factors = array(
-			'kg' => array(
-				'kg' => 1,
-				'g'  => 1000,
-				'lb' => 2.20462,
-				'oz' => 35.274,
-			),
-			'g'  => array(
-				'kg' => 0.001,
-				'g'  => 1,
-				'lb' => 0.00220462,
-				'oz' => 0.035274,
-			),
-			'lb' => array(
-				'kg' => 0.453592,
-				'g'  => 453.592,
-				'lb' => 1,
-				'oz' => 16,
-			),
-			'oz' => array(
-				'kg' => 0.0283495,
-				'g'  => 28.3495,
-				'lb' => 0.0625,
-				'oz' => 1,
-			),
-		);
-
-		if ( ! isset( $conversion_factors[ $shopify_unit_key ][ $store_weight_unit ] ) ) {
+		if ( ! isset( self::CONVERSION_FACTORS[ $shopify_unit_key ][ $store_weight_unit ] ) ) {
 			return (float) $weight;
 		}

-		return (float) $weight * $conversion_factors[ $shopify_unit_key ][ $store_weight_unit ];
+		return (float) $weight * self::CONVERSION_FACTORS[ $shopify_unit_key ][ $store_weight_unit ];

Also applies to: 490-521

plugins/woocommerce/tests/php/src/Internal/CLI/Migrator/Platforms/Shopify/ShopifyMapperTest.php (1)

537-563: Consider extracting test data builders

The helper methods create_simple_shopify_product and create_variable_shopify_product create complex test objects. Consider using a builder pattern or factory to make test data creation more flexible and maintainable.

Example:

class ShopifyProductBuilder {
    private $product;
    
    public function __construct() {
        $this->product = (object) [
            'id' => 'gid://shopify/Product/123456789',
            'status' => 'ACTIVE',
            // ... defaults
        ];
    }
    
    public function withTitle(string $title): self {
        $this->product->title = $title;
        return $this;
    }
    
    public function withVariants(array $variants): self {
        $this->product->variants = (object) ['edges' => $variants];
        return $this;
    }
    
    public function build(): object {
        return $this->product;
    }
}

Also applies to: 570-639

Configuration used: .coderabbit.yml
Review profile: CHILL
Plan: Pro

Learnt from: tpaksu
PR: woocommerce/woocommerce#59172
File: plugins/woocommerce/src/Internal/Fulfillments/Providers/MPLShippingProvider.php:14-21
Timestamp: 2025-06-26T10:47:27.212Z
Learning: In the WooCommerce fulfillments system, only the UPS shipping provider is currently fully implemented. All other shipping provider classes in plugins/woocommerce/src/Internal/Fulfillments/Providers/ are placeholders for future implementations, so empty shipping country arrays and stub methods in these classes are intentional and should not be flagged as issues.

Learnt from: gigitux
PR: woocommerce/woocommerce#59659
File: plugins/woocommerce/client/blocks/assets/js/blocks/add-to-cart-with-options/frontend.ts:136-147
Timestamp: 2025-07-22T09:30:43.528Z
Learning: In WooCommerce blocks TypeScript code, avoid type assertions (`as`) when accessing properties from unified stores. Instead, create proper union types that combine all the different store component types using `Partial<>` wrappers, and export the unified type to help third-party extenders. For example: `type UnifiedStore = BaseStore & Partial<StoreA> & Partial<StoreB>`.

Learnt from: tpaksu
PR: woocommerce/woocommerce#59172
File: plugins/woocommerce/src/Internal/Fulfillments/Providers/MPLShippingProvider.php:14-21
Timestamp: 2025-06-26T10:47:27.212Z
Learning: In the WooCommerce fulfillments system, only the UPS shipping provider is currently fully implemented. All other shipping provider classes in plugins/woocommerce/src/Internal/Fulfillments/Providers/ are placeholders for future implementations, so empty shipping country arrays and stub methods in these classes are intentional and should not be flagged as issues.

Learnt from: samueljseay
PR: woocommerce/woocommerce#58716
File: plugins/woocommerce/client/blocks/assets/js/blocks/mini-cart/iapi-frontend.ts:83-101
Timestamp: 2025-06-17T07:07:53.443Z
Learning: In WooCommerce blocks, when porting existing code patterns that have known issues (like parseInt truncating decimal money values), maintain consistency with existing implementation rather than making isolated fixes. The preference is for systematic refactoring approaches (like broader Dinero adoption) over piecemeal changes.

plugins/woocommerce/src/Internal/CLI/Migrator/Platforms/Shopify/ShopifyMapper.php (7)

420-420: Use numeric comparison for prices

When comparing prices as strings, '9.99' > '10.00' evaluates to true, which is incorrect. Cast both values to float before comparison.

-				if ( $variant_node->compareAtPrice && $variant_node->compareAtPrice > $variant_node->price ) { // phpcs:ignore WordPress.NamingConventions.ValidVariableName.UsedPropertyNotSnakeCase -- GraphQL uses camelCase.
+				if ( $variant_node->compareAtPrice && (float) $variant_node->compareAtPrice > (float) $variant_node->price ) { // phpcs:ignore WordPress.NamingConventions.ValidVariableName.UsedPropertyNotSnakeCase -- GraphQL uses camelCase.

---

436-436: Add null check for inventoryItem property

The code checks if 'inventoryItem' property exists but doesn't verify if it's not null before accessing its 'tracked' property.

-				$manage_stock                  = property_exists( $variant_node, 'inventoryItem' ) && $variant_node->inventoryItem->tracked; // phpcs:ignore WordPress.NamingConventions.ValidVariableName.UsedPropertyNotSnakeCase -- GraphQL uses camelCase.
+				$manage_stock                  = property_exists( $variant_node, 'inventoryItem' ) && $variant_node->inventoryItem && $variant_node->inventoryItem->tracked; // phpcs:ignore WordPress.NamingConventions.ValidVariableName.UsedPropertyNotSnakeCase -- GraphQL uses camelCase.

---

260-268: Define unit mapping as class constant

The weight unit mapping array should be defined as a class constant rather than recreating it on every method call.

+	/**
+	 * Weight unit mapping from Shopify to WooCommerce.
+	 */
+	private const UNIT_MAP = array(
+		'GRAMS'     => 'g',
+		'KILOGRAMS' => 'kg',
+		'POUNDS'    => 'lb',
+		'OUNCES'    => 'oz',
+	);
+
 	private function get_converted_weight( $weight, $weight_unit ): ?float {
 		if ( null === $weight || null === $weight_unit || (float) $weight <= 0 ) {
 			return null;
 		}
 
-		$unit_map = array(
-			'GRAMS'     => 'g',
-			'KILOGRAMS' => 'kg',
-			'POUNDS'    => 'lb',
-			'OUNCES'    => 'oz',
-		);
-
-		$shopify_unit_key = $unit_map[ $weight_unit ] ?? null;
+		$shopify_unit_key = self::UNIT_MAP[ $weight_unit ] ?? null;

---

290-321: Define conversion factors as class constant

The weight conversion factors array should be defined as a class constant for better performance.

+	/**
+	 * Weight conversion factors between units.
+	 */
+	private const CONVERSION_FACTORS = array(
+		'kg' => array(
+			'kg' => 1,
+			'g'  => 1000,
+			'lb' => 2.20462,
+			'oz' => 35.274,
+		),
+		'g'  => array(
+			'kg' => 0.001,
+			'g'  => 1,
+			'lb' => 0.00220462,
+			'oz' => 0.035274,
+		),
+		'lb' => array(
+			'kg' => 0.453592,
+			'g'  => 453.592,
+			'lb' => 1,
+			'oz' => 16,
+		),
+		'oz' => array(
+			'kg' => 0.0283495,
+			'g'  => 28.3495,
+			'lb' => 0.0625,
+			'oz' => 1,
+		),
+	);
+
 		// Fallback manual conversion.
-		$conversion_factors = array(
-			'kg' => array(
-				'kg' => 1,
-				'g'  => 1000,
-				'lb' => 2.20462,
-				'oz' => 35.274,
-			),
-			'g'  => array(
-				'kg' => 0.001,
-				'g'  => 1,
-				'lb' => 0.00220462,
-				'oz' => 0.035274,
-			),
-			'lb' => array(
-				'kg' => 0.453592,
-				'g'  => 453.592,
-				'lb' => 1,
-				'oz' => 16,
-			),
-			'oz' => array(
-				'kg' => 0.0283495,
-				'g'  => 28.3495,
-				'lb' => 0.0625,
-				'oz' => 1,
-			),
-		);
-
-		if ( ! isset( $conversion_factors[ $shopify_unit_key ][ $store_weight_unit ] ) ) {
+		if ( ! isset( self::CONVERSION_FACTORS[ $shopify_unit_key ][ $store_weight_unit ] ) ) {
 			return (float) $weight;
 		}
 
-		return (float) $weight * $conversion_factors[ $shopify_unit_key ][ $store_weight_unit ];
+		return (float) $weight * self::CONVERSION_FACTORS[ $shopify_unit_key ][ $store_weight_unit ];

---

330-332: Method name is misleading - implement proper HTML sanitization

The method name sanitize_product_description suggests it sanitizes HTML for security, but it only trims whitespace. This could lead to XSS vulnerabilities.

 	private function sanitize_product_description( string $html ): string {
-		return trim( $html );
+		// Use WordPress built-in sanitization
+		return wp_kses_post( trim( $html ) );
 	}

---

509-509: Use numeric comparison for variant prices

Same issue as line 420 - string comparison of prices can lead to incorrect results.

-					if ( $variant_node->compareAtPrice && (float) $variant_node->compareAtPrice > (float) $variant_node->price ) { // phpcs:ignore WordPress.NamingConventions.ValidVariableName.UsedPropertyNotSnakeCase -- GraphQL uses camelCase.
+					if ( $variant_node->compareAtPrice && (float) $variant_node->compareAtPrice > (float) $variant_node->price ) { // phpcs:ignore WordPress.NamingConventions.ValidVariableName.UsedPropertyNotSnakeCase -- GraphQL uses camelCase.

---

525-525: Add null check for variant inventoryItem

Same null pointer issue as line 436.

-					$manage_stock                     = property_exists( $variant_node, 'inventoryItem' ) && $variant_node->inventoryItem->tracked; // phpcs:ignore WordPress.NamingConventions.ValidVariableName.UsedPropertyNotSnakeCase -- GraphQL uses camelCase.
+					$manage_stock                     = property_exists( $variant_node, 'inventoryItem' ) && is_object( $variant_node->inventoryItem ) && $variant_node->inventoryItem->tracked; // phpcs:ignore WordPress.NamingConventions.ValidVariableName.UsedPropertyNotSnakeCase -- GraphQL uses camelCase.

plugins/woocommerce/tests/php/src/Internal/CLI/Migrator/Platforms/Shopify/ShopifyMapperTest.php (1)

130-133: Fix property names to match Shopify GraphQL schema

Multiple properties use snake_case but should use camelCase to match Shopify's GraphQL API.

-		$shopify_product->product_type          = 'Apparel';
+		$shopify_product->productType          = 'Apparel';
 		$shopify_product->category              = (object) array( 'name' => 'Shirts' );
-		$shopify_product->is_gift_card          = false;
-		$shopify_product->requires_selling_plan = true;
+		$shopify_product->isGiftCard          = false;
+		$shopify_product->requiresSellingPlan = true;

Configuration used: .coderabbit.yml
Review profile: CHILL
Plan: Pro

Learnt from: tpaksu
PR: woocommerce/woocommerce#59172
File: plugins/woocommerce/src/Internal/Fulfillments/Providers/MPLShippingProvider.php:14-21
Timestamp: 2025-06-26T10:47:27.212Z
Learning: In the WooCommerce fulfillments system, only the UPS shipping provider is currently fully implemented. All other shipping provider classes in plugins/woocommerce/src/Internal/Fulfillments/Providers/ are placeholders for future implementations, so empty shipping country arrays and stub methods in these classes are intentional and should not be flagged as issues.

Learnt from: gigitux
PR: woocommerce/woocommerce#59659
File: plugins/woocommerce/client/blocks/assets/js/blocks/add-to-cart-with-options/frontend.ts:136-147
Timestamp: 2025-07-22T09:30:43.528Z
Learning: In WooCommerce blocks TypeScript code, avoid type assertions (`as`) when accessing properties from unified stores. Instead, create proper union types that combine all the different store component types using `Partial<>` wrappers, and export the unified type to help third-party extenders. For example: `type UnifiedStore = BaseStore & Partial<StoreA> & Partial<StoreB>`.

Learnt from: dinhtungdu
PR: woocommerce/woocommerce#59900
File: plugins/woocommerce/client/blocks/assets/js/blocks/product-filters/inner-blocks/attribute-filter/inspector.tsx:0-0
Timestamp: 2025-07-24T05:37:00.907Z
Learning: The DisplayStyleSwitcher component in plugins/woocommerce/client/blocks/assets/js/blocks/product-filters/components/display-style-switcher/index.tsx has been updated so that its onChange prop accepts only a string type (not string | number | undefined), eliminating the need for type assertions when using this component.

Learnt from: tpaksu
PR: woocommerce/woocommerce#59172
File: plugins/woocommerce/src/Internal/Fulfillments/Providers/MPLShippingProvider.php:14-21
Timestamp: 2025-06-26T10:47:27.212Z
Learning: In the WooCommerce fulfillments system, only the UPS shipping provider is currently fully implemented. All other shipping provider classes in plugins/woocommerce/src/Internal/Fulfillments/Providers/ are placeholders for future implementations, so empty shipping country arrays and stub methods in these classes are intentional and should not be flagged as issues.

Learnt from: samueljseay
PR: woocommerce/woocommerce#58716
File: plugins/woocommerce/client/blocks/assets/js/blocks/mini-cart/iapi-frontend.ts:83-101
Timestamp: 2025-06-17T07:07:53.443Z
Learning: In WooCommerce blocks, when porting existing code patterns that have known issues (like parseInt truncating decimal money values), maintain consistency with existing implementation rather than making isolated fixes. The preference is for systematic refactoring approaches (like broader Dinero adoption) over piecemeal changes.

Learnt from: senadir
PR: woocommerce/woocommerce#59426
File: plugins/woocommerce/client/legacy/js/frontend/a8c-address-autocomplete-service.js:355-355
Timestamp: 2025-07-08T09:14:47.894Z
Learning: In the WooCommerce address autocomplete system, input sanitization happens upstream in address-autocomplete.js before data reaches a8c-address-autocomplete-service.js. The trim() operation in the service file is for optimization purposes (to skip API requests when only spaces are added), not for security sanitization.

Learnt from: CR
PR: woocommerce/woocommerce#0
File: .cursor/rules/code-quality.mdc:0-0
Timestamp: 2025-07-18T14:54:36.232Z
Learning: Applies to **/*.{php,js,jsx,ts,tsx} : Sanitize and validate any potentially dangerous inputs

Learnt from: lysyjan
PR: woocommerce/woocommerce#59632
File: packages/js/email-editor/src/layouts/flex-email.tsx:116-122
Timestamp: 2025-07-14T10:41:46.200Z
Learning: In WooCommerce projects, formatting suggestions should respect the project's Prettier configuration and linting rules. Changes that would break the lint job should be avoided, even if they appear to improve readability.

plugins/woocommerce/src/Internal/CLI/Migrator/Platforms/Shopify/ShopifyMapper.php (4)

341-343: Method name is misleading - no actual HTML sanitization performed

The method name sanitize_product_description suggests it sanitizes HTML for security, but it only trims whitespace. This could lead to XSS vulnerabilities if untrusted HTML is passed through.

Either rename the method to trim_product_description or implement proper HTML sanitization using wp_kses_post().

---

431-437: Use numeric comparison for price values

The comparison should use explicit numeric casting rather than relying on PHP's type juggling. When comparing prices, explicit float casting ensures accurate comparison.

-			if ( $variant_node->compareAtPrice && $variant_node->compareAtPrice > $variant_node->price ) { // phpcs:ignore WordPress.NamingConventions.ValidVariableName.UsedPropertyNotSnakeCase -- GraphQL uses camelCase.
+			if ( $variant_node->compareAtPrice && (float) $variant_node->compareAtPrice > (float) $variant_node->price ) { // phpcs:ignore WordPress.NamingConventions.ValidVariableName.UsedPropertyNotSnakeCase -- GraphQL uses camelCase.

---

447-453: Potential null pointer exception when accessing inventoryItem->tracked

The code checks if 'inventoryItem' property exists but doesn't verify if it's not null before accessing its 'tracked' property.

-				$manage_stock                  = property_exists( $variant_node, 'inventoryItem' ) && $variant_node->inventoryItem->tracked; // phpcs:ignore WordPress.NamingConventions.ValidVariableName.UsedPropertyNotSnakeCase -- GraphQL uses camelCase.
+				$manage_stock                  = property_exists( $variant_node, 'inventoryItem' ) && $variant_node->inventoryItem && $variant_node->inventoryItem->tracked; // phpcs:ignore WordPress.NamingConventions.ValidVariableName.UsedPropertyNotSnakeCase -- GraphQL uses camelCase.

---

536-542: Potential null pointer exception when accessing inventoryItem->tracked

Same issue as in the simple product section - the code doesn't verify if inventoryItem is not null before accessing its tracked property.

-					$manage_stock                     = property_exists( $variant_node, 'inventoryItem' ) && $variant_node->inventoryItem->tracked; // phpcs:ignore WordPress.NamingConventions.ValidVariableName.UsedPropertyNotSnakeCase -- GraphQL uses camelCase.
+					$manage_stock                     = property_exists( $variant_node, 'inventoryItem' ) && $variant_node->inventoryItem && $variant_node->inventoryItem->tracked; // phpcs:ignore WordPress.NamingConventions.ValidVariableName.UsedPropertyNotSnakeCase -- GraphQL uses camelCase.

plugins/woocommerce/src/Internal/CLI/Migrator/Platforms/Shopify/ShopifyMapper.php (1)

423-484: Consider extracting duplicate variant mapping logic

The logic for mapping variant data (price, SKU, stock, weight) is duplicated between mapSimpleProductData and mapVariableProductData. Consider extracting this into a private helper method like mapVariantData($variant_node) to reduce duplication and ensure consistent behavior.

Example refactoring:

private function mapVariantData( $variant_node ): array {
    $variant_data = array();
    
    // Price logic
    if ( $this->should_process( 'price' ) ) {
        if ( $variant_node->compareAtPrice && (float) $variant_node->compareAtPrice > (float) $variant_node->price ) {
            $variant_data['regular_price'] = $variant_node->compareAtPrice;
            $variant_data['sale_price'] = $variant_node->price;
        } else {
            $variant_data['regular_price'] = $variant_node->price;
            $variant_data['sale_price'] = null;
        }
    }
    
    // SKU, stock, weight logic...
    
    return $variant_data;
}

Also applies to: 493-587

Configuration used: .coderabbit.yml
Review profile: CHILL
Plan: Pro

Learnt from: tpaksu
PR: woocommerce/woocommerce#59172
File: plugins/woocommerce/src/Internal/Fulfillments/Providers/MPLShippingProvider.php:14-21
Timestamp: 2025-06-26T10:47:27.212Z
Learning: In the WooCommerce fulfillments system, only the UPS shipping provider is currently fully implemented. All other shipping provider classes in plugins/woocommerce/src/Internal/Fulfillments/Providers/ are placeholders for future implementations, so empty shipping country arrays and stub methods in these classes are intentional and should not be flagged as issues.

Learnt from: gigitux
PR: woocommerce/woocommerce#59659
File: plugins/woocommerce/client/blocks/assets/js/blocks/add-to-cart-with-options/frontend.ts:136-147
Timestamp: 2025-07-22T09:30:43.528Z
Learning: In WooCommerce blocks TypeScript code, avoid type assertions (`as`) when accessing properties from unified stores. Instead, create proper union types that combine all the different store component types using `Partial<>` wrappers, and export the unified type to help third-party extenders. For example: `type UnifiedStore = BaseStore & Partial<StoreA> & Partial<StoreB>`.

Learnt from: tpaksu
PR: woocommerce/woocommerce#59172
File: plugins/woocommerce/src/Internal/Fulfillments/Providers/MPLShippingProvider.php:14-21
Timestamp: 2025-06-26T10:47:27.212Z
Learning: In the WooCommerce fulfillments system, only the UPS shipping provider is currently fully implemented. All other shipping provider classes in plugins/woocommerce/src/Internal/Fulfillments/Providers/ are placeholders for future implementations, so empty shipping country arrays and stub methods in these classes are intentional and should not be flagged as issues.

Learnt from: samueljseay
PR: woocommerce/woocommerce#58716
File: plugins/woocommerce/client/blocks/assets/js/blocks/mini-cart/iapi-frontend.ts:83-101
Timestamp: 2025-06-17T07:07:53.443Z
Learning: In WooCommerce blocks, when porting existing code patterns that have known issues (like parseInt truncating decimal money values), maintain consistency with existing implementation rather than making isolated fixes. The preference is for systematic refactoring approaches (like broader Dinero adoption) over piecemeal changes.

Learnt from: senadir
PR: woocommerce/woocommerce#59426
File: plugins/woocommerce/client/legacy/js/frontend/a8c-address-autocomplete-service.js:355-355
Timestamp: 2025-07-08T09:14:47.894Z
Learning: In the WooCommerce address autocomplete system, input sanitization happens upstream in address-autocomplete.js before data reaches a8c-address-autocomplete-service.js. The trim() operation in the service file is for optimization purposes (to skip API requests when only spaces are added), not for security sanitization.

Learnt from: CR
PR: woocommerce/woocommerce#0
File: .cursor/rules/code-quality.mdc:0-0
Timestamp: 2025-07-18T14:54:36.232Z
Learning: Applies to **/*.{php,js,jsx,ts,tsx} : Sanitize and validate any potentially dangerous inputs

Learnt from: lysyjan
PR: woocommerce/woocommerce#59632
File: packages/js/email-editor/src/layouts/flex-email.tsx:116-122
Timestamp: 2025-07-14T10:41:46.200Z
Learning: In WooCommerce projects, formatting suggestions should respect the project's Prettier configuration and linting rules. Changes that would break the lint job should be avoided, even if they appear to improve readability.

plugins/woocommerce/src/Internal/CLI/Migrator/Platforms/Shopify/ShopifyMapper.php (5)

421-421: Fix string comparison for prices

String comparison of prices can produce incorrect results (e.g., '9.99' > '10.00' evaluates to true).

---

510-510: Fix string comparison for prices in variations

String comparison of prices can produce incorrect results.

---

437-437: Add null check for inventoryItem before accessing tracked property

The code checks if inventoryItem exists but doesn't verify it's not null.

---

526-526: Add null check for inventoryItem in variations

The code checks if inventoryItem exists but doesn't verify it's not null.

---

331-333: Method name is misleading - implement proper HTML sanitization

The method name suggests HTML sanitization but only trims whitespace, which could lead to XSS vulnerabilities.

plugins/woocommerce/tests/php/src/Internal/CLI/Migrator/Platforms/Shopify/ShopifyMapperTest.php (2)

129-132: Fix property names to match Shopify GraphQL schema

Test data should use camelCase to match actual Shopify API responses.

---

508-528: Add test for HTML sanitization

Should verify that HTML content is properly sanitized to prevent XSS attacks.

plugins/woocommerce/src/Internal/CLI/Migrator/Platforms/Shopify/ShopifyMapper.php (1)

172-213: Refactor duplicated property checking logic

The pattern of checking both camelCase and snake_case properties is repeated. Extract this into a helper method to reduce duplication.

Add a helper method:

private function get_property_value( object $obj, string $camel_case_name, string $snake_case_name ) {
    if ( property_exists( $obj, $camel_case_name ) && $obj->$camel_case_name !== null ) {
        return $obj->$camel_case_name;
    }
    if ( property_exists( $obj, $snake_case_name ) && $obj->$snake_case_name !== null ) {
        return $obj->$snake_case_name;
    }
    return null;
}

Then simplify the classification method:

-    $product_type = null;
-    if ( property_exists( $shopify_product, 'productType' ) && $shopify_product->productType ) {
-        $product_type = $shopify_product->productType;
-    } elseif ( property_exists( $shopify_product, 'product_type' ) && $shopify_product->product_type ) {
-        $product_type = $shopify_product->product_type;
-    }
+    $product_type = $this->get_property_value( $shopify_product, 'productType', 'product_type' );

plugins/woocommerce/tests/php/src/Internal/CLI/Migrator/Platforms/Shopify/ShopifyMapperTest.php (1)

18-637: Consider adding security-focused test cases

While the test coverage is comprehensive, consider adding tests for:

1. SQL injection attempts in product names/descriptions
2. Script injection in metafields
3. Path traversal attempts in image URLs

Example test to add:

public function test_security_validation() {
    $shopify_product = $this->create_simple_shopify_product();
    $shopify_product->title = "'; DROP TABLE products; --";
    $shopify_product->descriptionHtml = '<script>alert("XSS")</script><p>Safe</p>';
    
    $result = $this->mapper->map_product_data( $shopify_product );
    
    // Verify dangerous input is properly handled
    $this->assertStringNotContainsString( 'DROP TABLE', $result['name'] );
    $this->assertStringNotContainsString( '<script>', $result['description'] );
}

Configuration used: .coderabbit.yml
Review profile: CHILL
Plan: Pro

Learnt from: tpaksu
PR: woocommerce/woocommerce#59172
File: plugins/woocommerce/src/Internal/Fulfillments/Providers/MPLShippingProvider.php:14-21
Timestamp: 2025-06-26T10:47:27.212Z
Learning: In the WooCommerce fulfillments system, only the UPS shipping provider is currently fully implemented. All other shipping provider classes in plugins/woocommerce/src/Internal/Fulfillments/Providers/ are placeholders for future implementations, so empty shipping country arrays and stub methods in these classes are intentional and should not be flagged as issues.

Learnt from: gigitux
PR: woocommerce/woocommerce#59659
File: plugins/woocommerce/client/blocks/assets/js/blocks/add-to-cart-with-options/frontend.ts:136-147
Timestamp: 2025-07-22T09:30:43.528Z
Learning: In WooCommerce blocks TypeScript code, avoid type assertions (`as`) when accessing properties from unified stores. Instead, create proper union types that combine all the different store component types using `Partial<>` wrappers, and export the unified type to help third-party extenders. For example: `type UnifiedStore = BaseStore & Partial<StoreA> & Partial<StoreB>`.

Learnt from: dinhtungdu
PR: woocommerce/woocommerce#59900
File: plugins/woocommerce/client/blocks/assets/js/blocks/product-filters/inner-blocks/attribute-filter/inspector.tsx:0-0
Timestamp: 2025-07-24T05:37:00.907Z
Learning: The DisplayStyleSwitcher component in plugins/woocommerce/client/blocks/assets/js/blocks/product-filters/components/display-style-switcher/index.tsx has been updated so that its onChange prop accepts only a string type (not string | number | undefined), eliminating the need for type assertions when using this component.

Learnt from: CR
PR: woocommerce/woocommerce#0
File: .cursor/rules/code-quality.mdc:0-0
Timestamp: 2025-07-18T14:54:36.232Z
Learning: Applies to **/*.{php,js,jsx,ts,tsx} : Sanitize and validate any potentially dangerous inputs

Learnt from: tpaksu
PR: woocommerce/woocommerce#59172
File: plugins/woocommerce/src/Internal/Fulfillments/Providers/MPLShippingProvider.php:14-21
Timestamp: 2025-06-26T10:47:27.212Z
Learning: In the WooCommerce fulfillments system, only the UPS shipping provider is currently fully implemented. All other shipping provider classes in plugins/woocommerce/src/Internal/Fulfillments/Providers/ are placeholders for future implementations, so empty shipping country arrays and stub methods in these classes are intentional and should not be flagged as issues.

Learnt from: samueljseay
PR: woocommerce/woocommerce#58716
File: plugins/woocommerce/client/blocks/assets/js/blocks/mini-cart/iapi-frontend.ts:83-101
Timestamp: 2025-06-17T07:07:53.443Z
Learning: In WooCommerce blocks, when porting existing code patterns that have known issues (like parseInt truncating decimal money values), maintain consistency with existing implementation rather than making isolated fixes. The preference is for systematic refactoring approaches (like broader Dinero adoption) over piecemeal changes.

Learnt from: senadir
PR: woocommerce/woocommerce#59426
File: plugins/woocommerce/client/legacy/js/frontend/a8c-address-autocomplete-service.js:355-355
Timestamp: 2025-07-08T09:14:47.894Z
Learning: In the WooCommerce address autocomplete system, input sanitization happens upstream in address-autocomplete.js before data reaches a8c-address-autocomplete-service.js. The trim() operation in the service file is for optimization purposes (to skip API requests when only spaces are added), not for security sanitization.

Learnt from: lysyjan
PR: woocommerce/woocommerce#59632
File: packages/js/email-editor/src/layouts/flex-email.tsx:116-122
Timestamp: 2025-07-14T10:41:46.200Z
Learning: In WooCommerce projects, formatting suggestions should respect the project's Prettier configuration and linting rules. Changes that would break the lint job should be avoided, even if they appear to improve readability.

plugins/woocommerce/src/Internal/CLI/Migrator/Platforms/Shopify/ShopifyMapper.php (5)

95-117: Add input validation for the Shopify product object

The method accepts an object parameter but doesn't validate its structure before accessing properties. This could cause runtime errors when accessing required properties.

Add validation at the start of the method:

 public function map_product_data( object $shopify_product ): array {
+    // Validate required fields
+    if ( ! property_exists( $shopify_product, 'id' ) || 
+         ! property_exists( $shopify_product, 'title' ) || 
+         ! property_exists( $shopify_product, 'handle' ) ) {
+        throw new \InvalidArgumentException( 'Invalid Shopify product object: missing required fields' );
+    }
+
     $is_variable = $this->is_variable_product( $shopify_product );

---

418-424: Fix price comparison logic

The price comparison should use numeric comparison rather than string comparison. String comparison can produce incorrect results (e.g., '9.99' > '10.00' evaluates to true).

-				if ( $variant_node->compareAtPrice && $variant_node->compareAtPrice > $variant_node->price ) {
+				if ( $variant_node->compareAtPrice && (float) $variant_node->compareAtPrice > (float) $variant_node->price ) {

---

433-433: Add null check for inventoryItem access

Potential null pointer exception when accessing $variant_node->inventoryItem->tracked. The code checks if the property exists but doesn't verify if it's not null.

-				$manage_stock                  = property_exists( $variant_node, 'inventoryItem' ) && $variant_node->inventoryItem->tracked;
+				$manage_stock                  = property_exists( $variant_node, 'inventoryItem' ) && $variant_node->inventoryItem && $variant_node->inventoryItem->tracked;

---

505-511: Fix price comparison logic in variations

Same string comparison issue as in simple product mapping. Use numeric comparison for accurate price comparison.

-					if ( $variant_node->compareAtPrice && (float) $variant_node->compareAtPrice > (float) $variant_node->price ) {
+					if ( $variant_node->compareAtPrice && (float) $variant_node->compareAtPrice > (float) $variant_node->price ) {

---

520-520: Add null check for inventoryItem access in variations

Same null pointer issue as in simple product mapping. Add proper null checking.

-					$manage_stock                     = property_exists( $variant_node, 'inventoryItem' ) && $variant_node->inventoryItem->tracked;
+					$manage_stock                     = property_exists( $variant_node, 'inventoryItem' ) && $variant_node->inventoryItem && $variant_node->inventoryItem->tracked;

plugins/woocommerce/src/Internal/CLI/Migrator/Platforms/Shopify/ShopifyMapper.php (1)

330-345: Consider renaming method for clarity

While the admin-level context makes HTML sanitization unnecessary as discussed in previous reviews, consider renaming sanitize_product_description to trim_product_description to better reflect its actual behavior.

The should_process method is well-implemented for selective field filtering.

Configuration used: .coderabbit.yml
Review profile: CHILL
Plan: Pro

Learnt from: tpaksu
PR: woocommerce/woocommerce#59172
File: plugins/woocommerce/src/Internal/Fulfillments/Providers/MPLShippingProvider.php:14-21
Timestamp: 2025-06-26T10:47:27.212Z
Learning: In the WooCommerce fulfillments system, only the UPS shipping provider is currently fully implemented. All other shipping provider classes in plugins/woocommerce/src/Internal/Fulfillments/Providers/ are placeholders for future implementations, so empty shipping country arrays and stub methods in these classes are intentional and should not be flagged as issues.

Learnt from: gigitux
PR: woocommerce/woocommerce#59659
File: plugins/woocommerce/client/blocks/assets/js/blocks/add-to-cart-with-options/frontend.ts:136-147
Timestamp: 2025-07-22T09:30:43.528Z
Learning: In WooCommerce blocks TypeScript code, avoid type assertions (`as`) when accessing properties from unified stores. Instead, create proper union types that combine all the different store component types using `Partial<>` wrappers, and export the unified type to help third-party extenders. For example: `type UnifiedStore = BaseStore & Partial<StoreA> & Partial<StoreB>`.

Learnt from: tpaksu
PR: woocommerce/woocommerce#59172
File: plugins/woocommerce/src/Internal/Fulfillments/Providers/MPLShippingProvider.php:14-21
Timestamp: 2025-06-26T10:47:27.212Z
Learning: In the WooCommerce fulfillments system, only the UPS shipping provider is currently fully implemented. All other shipping provider classes in plugins/woocommerce/src/Internal/Fulfillments/Providers/ are placeholders for future implementations, so empty shipping country arrays and stub methods in these classes are intentional and should not be flagged as issues.

Learnt from: samueljseay
PR: woocommerce/woocommerce#58716
File: plugins/woocommerce/client/blocks/assets/js/blocks/mini-cart/iapi-frontend.ts:83-101
Timestamp: 2025-06-17T07:07:53.443Z
Learning: In WooCommerce blocks, when porting existing code patterns that have known issues (like parseInt truncating decimal money values), maintain consistency with existing implementation rather than making isolated fixes. The preference is for systematic refactoring approaches (like broader Dinero adoption) over piecemeal changes.

Learnt from: senadir
PR: woocommerce/woocommerce#59426
File: plugins/woocommerce/client/legacy/js/frontend/a8c-address-autocomplete-service.js:355-355
Timestamp: 2025-07-08T09:14:47.894Z
Learning: In the WooCommerce address autocomplete system, input sanitization happens upstream in address-autocomplete.js before data reaches a8c-address-autocomplete-service.js. The trim() operation in the service file is for optimization purposes (to skip API requests when only spaces are added), not for security sanitization.

Learnt from: CR
PR: woocommerce/woocommerce#0
File: .cursor/rules/code-quality.mdc:0-0
Timestamp: 2025-07-18T14:54:36.232Z
Learning: Applies to **/*.{php,js,jsx,ts,tsx} : Sanitize and validate any potentially dangerous inputs

Learnt from: lysyjan
PR: woocommerce/woocommerce#59632
File: packages/js/email-editor/src/layouts/flex-email.tsx:116-122
Timestamp: 2025-07-14T10:41:46.200Z
Learning: In WooCommerce projects, formatting suggestions should respect the project's Prettier configuration and linting rules. Changes that would break the lint job should be avoided, even if they appear to improve readability.

Learnt from: nerrad
PR: woocommerce/woocommerce#60176
File: plugins/woocommerce/client/legacy/css/admin.scss:9088-9105
Timestamp: 2025-08-04T00:21:51.440Z
Learning: WooCommerce is currently in the midst of an admin redesign project, so temporary/short-term CSS solutions for admin pages are preferred over long-term refactoring when addressing immediate needs.

Learnt from: mreishus
PR: woocommerce/woocommerce#58817
File: plugins/woocommerce/includes/wc-product-functions.php:140-140
Timestamp: 2025-06-13T23:52:46.221Z
Learning: In WooCommerce's wc_delete_product_transients function, the context check includes both $is_admin_page (for regular admin screens) and $is_privileged_ajax (for AJAX requests from users with edit_products capability), ensuring that legitimate admin AJAX operations like product imports/exports can still delete transients.

Learnt from: opr
PR: woocommerce/woocommerce#0
File: :0-0
Timestamp: 2025-06-20T17:38:16.565Z
Learning: WooCommerce legacy JavaScript files in plugins/woocommerce/client/legacy/js/ must use older JavaScript syntax and cannot use modern features like optional chaining (?.) due to browser compatibility requirements. Explicit null checking with && operators should be used instead.

Learnt from: dinhtungdu
PR: woocommerce/woocommerce#60142
File: plugins/woocommerce/src/Internal/ProductFilters/TaxonomyHierarchyData.php:71-93
Timestamp: 2025-08-01T05:52:57.768Z
Learning: In plugins/woocommerce/src/Internal/ProductFilters/TaxonomyHierarchyData.php, the get_descendants() and get_ancestors() methods don't need extensive input validation because: 1) the taxonomy parameter is always validated upstream in the controlled WooCommerce core context, and 2) the null coalescing operator (??) already efficiently handles invalid term_id keys in the returned map.

Learnt from: NeosinneR
PR: woocommerce/woocommerce#60129
File: plugins/woocommerce/includes/wc-coupon-functions.php:145-154
Timestamp: 2025-07-31T11:18:02.478Z
Learning: In WooCommerce codebase, when table names are hardcoded (like `$wpdb->prefix . 'wc_order_coupon_lookup'`), the preference is to maintain consistency with existing patterns throughout the codebase rather than making isolated security improvements when the risk is minimal (since $wpdb->prefix is controlled by WordPress and table names are hardcoded constants).

Learnt from: dinhtungdu
PR: woocommerce/woocommerce#59499
File: plugins/woocommerce/src/Internal/ProductFilters/QueryClauses.php:327-332
Timestamp: 2025-07-10T04:22:27.648Z
Learning: In the WooCommerce ProductFilters QueryClauses class, the $chosen_taxonomies parameter in add_taxonomy_clauses() already contains only validated public product taxonomies. The validation occurs upstream in the Params class during parameter registration, so additional taxonomy existence validation in the processing methods is redundant.

plugins/woocommerce/tests/php/src/Internal/CLI/Migrator/Platforms/Shopify/ShopifyMapperTest.php (1)

157-224: Strong pricing and inventory test coverage

Good validation of pricing logic including sale detection via compareAtPrice, inventory management, and stock policies. The weight conversion test validates basic functionality but could be enhanced.

Consider adding more comprehensive weight conversion tests:

/**
 * Test weight conversion from different units.
 */
public function test_comprehensive_weight_conversion() {
    // Test conversion from different Shopify units
    $units_to_test = array(
        'GRAMS' => 1000.0,
        'KILOGRAMS' => 1.0, 
        'POUNDS' => 2.20462,
        'OUNCES' => 35.274,
    );
    
    foreach ( $units_to_test as $unit => $value ) {
        $shopify_product = $this->create_simple_shopify_product();
        $shopify_product->variants->edges[0]->node->inventoryItem = (object) array(
            'measurement' => (object) array(
                'weight' => (object) array(
                    'value' => $value,
                    'unit'  => $unit,
                ),
            ),
        );
        
        $result = $this->mapper->map_product_data( $shopify_product );
        $this->assertIsFloat( $result['weight'] );
        $this->assertGreaterThan( 0, $result['weight'] );
    }
}

Configuration used: .coderabbit.yml
Review profile: CHILL
Plan: Pro

Learnt from: tpaksu
PR: woocommerce/woocommerce#59172
File: plugins/woocommerce/src/Internal/Fulfillments/Providers/MPLShippingProvider.php:14-21
Timestamp: 2025-06-26T10:47:27.212Z
Learning: In the WooCommerce fulfillments system, only the UPS shipping provider is currently fully implemented. All other shipping provider classes in plugins/woocommerce/src/Internal/Fulfillments/Providers/ are placeholders for future implementations, so empty shipping country arrays and stub methods in these classes are intentional and should not be flagged as issues.

Learnt from: gigitux
PR: woocommerce/woocommerce#59659
File: plugins/woocommerce/client/blocks/assets/js/blocks/add-to-cart-with-options/frontend.ts:136-147
Timestamp: 2025-07-22T09:30:43.528Z
Learning: In WooCommerce blocks TypeScript code, avoid type assertions (`as`) when accessing properties from unified stores. Instead, create proper union types that combine all the different store component types using `Partial<>` wrappers, and export the unified type to help third-party extenders. For example: `type UnifiedStore = BaseStore & Partial<StoreA> & Partial<StoreB>`.

Learnt from: dinhtungdu
PR: woocommerce/woocommerce#59900
File: plugins/woocommerce/client/blocks/assets/js/blocks/product-filters/inner-blocks/attribute-filter/inspector.tsx:0-0
Timestamp: 2025-07-24T05:37:00.907Z
Learning: The DisplayStyleSwitcher component in plugins/woocommerce/client/blocks/assets/js/blocks/product-filters/components/display-style-switcher/index.tsx has been updated so that its onChange prop accepts only a string type (not string | number | undefined), eliminating the need for type assertions when using this component.

Learnt from: CR
PR: woocommerce/woocommerce#0
File: .cursor/rules/code-quality.mdc:0-0
Timestamp: 2025-07-18T14:54:36.232Z
Learning: Applies to **/*.{php,js,jsx,ts,tsx} : Sanitize and validate any potentially dangerous inputs

plugins/woocommerce/tests/php/src/Internal/CLI/Migrator/Platforms/Shopify/ShopifyMapperTest.php (2)

508-528: Enhance malformed data coverage: nulls/invalid enums/incorrect types

Extend the malformed data test to include:

• Null/empty title/handle with fallbacks.
• Invalid status (assert safe default).
• Non-array tags/collections.
• Missing variants (ensure pricing fields handled gracefully).

Example:

$bad = (object) array(
    'id' => null,
    'title' => null,
    'handle' => null,
    'status' => 'INVALID',
    'tags' => null,
    'collections' => null,
);
$r = $this->mapper->map_product_data( $bad );
$this->assertIsArray( $r );
$this->assertArrayHasKey( 'name', $r );
$this->assertContains( $r['status'], array( 'draft', 'publish' ) );
$this->assertEquals( array(), $r['tags'] );
$this->assertEquals( array(), $r['categories'] );

---

508-528: Add sanitization tests for HTML/script content in title/description

Per security guidelines, add tests ensuring script tags are stripped from descriptionHtml (and possibly title) while preserving safe content. This was raised earlier as well.

Example:

public function test_html_sanitization() {
    $p = $this->create_simple_shopify_product();
    $p->title           = '<script>alert(1)</script>Safe Title';
    $p->descriptionHtml = '<script>alert("XSS")</script><p>Safe</p>';

    $r = $this->mapper->map_product_data( $p );

    $this->assertStringNotContainsString( '<script', $r['name'] );
    $this->assertStringNotContainsString( '<script', $r['description'] );
    $this->assertStringContainsString( 'Safe', $r['description'] );
}

plugins/woocommerce/tests/php/src/Internal/CLI/Migrator/Platforms/Shopify/ShopifyMapperTest.php (10)

45-50: Basic smoke test is appropriate

Verifies the method returns an array. Consider also asserting a couple of required keys (e.g., name, status) to make this smoke test a bit more meaningful.

---

128-133: Add a camelCase variant for classification fields

You’re testing snake_case compatibility here (product_type, is_gift_card, requires_selling_plan). Add a camelCase variant test (productType, isGiftCard, requiresSellingPlan) to lock in dual-compat behavior.

Example addition:

public function test_product_classification_mapping_camel_case() {
    $p = $this->create_simple_shopify_product();
    $p->productType          = 'Apparel';
    $p->category             = (object) array( 'name' => 'Shirts' );
    $p->isGiftCard           = false;
    $p->requiresSellingPlan  = true;

    $r = $this->mapper->map_product_data( $p );

    $this->assertEquals( array( 'name' => 'Apparel', 'slug' => 'apparel' ), $r['product_type'] );
    $this->assertEquals( array( 'name' => 'Shirts', 'slug' => 'shirts' ), $r['standard_category'] );
    $this->assertFalse( $r['is_gift_card'] );
    $this->assertTrue( $r['requires_subscription'] );
}

---

157-172: Sale price logic covered; consider a non-sale guard

You verify compareAtPrice > price results in sale. Add a guard case (compareAtPrice <= price) to assert sale_price remains null and regular_price equals price.

Example:

$same_price = $this->create_simple_shopify_product();
$same_price->variants->edges[0]->node->compareAtPrice = '25.00';
$r = $this->mapper->map_product_data( $same_price );
$this->assertEquals( '25.00', $r['regular_price'] );
$this->assertNull( $r['sale_price'] );

---

205-224: Weight conversion test is minimal; add unit variety and invalids

Consider adding cases for KILOGRAMS, POUNDS, OUNCES and an invalid unit. This helps ensure robust conversion and graceful fallback.

Example snippet:

// KG
$kg = $this->create_simple_shopify_product();
$kg->variants->edges[0]->node->inventoryItem = (object) array(
    'tracked' => true,
    'measurement' => (object) array( 'weight' => (object) array( 'value' => 1.5, 'unit' => 'KILOGRAMS' ) ),
);
$r = $this->mapper->map_product_data( $kg );
$this->assertIsFloat( $r['weight'] );

// Invalid unit
$bad = $this->create_simple_shopify_product();
$bad->variants->edges[0]->node->inventoryItem = (object) array(
    'tracked' => true,
    'measurement' => (object) array( 'weight' => (object) array( 'value' => 10, 'unit' => 'STONES' ) ),
);
$r = $this->mapper->map_product_data( $bad );
$this->assertTrue( ! isset( $r['weight'] ) || null === $r['weight'] );

---

266-299: Variation mapping is good; extend with stock/sale/weight assertions

Add checks for per-variation manage_stock/stock_status, and sale logic (variant compareAtPrice > price). If weight can be variant-specific, assert it as well.

Example:

$vp = $this->create_variable_shopify_product();
$vp->variants->edges[0]->node->compareAtPrice = '22.00';
$vp->variants->edges[0]->node->inventoryQuantity = 0;
$vp->variants->edges[0]->node->inventoryItem = (object) array(
    'tracked' => true,
    'measurement' => (object) array( 'weight' => (object) array( 'value' => 500, 'unit' => 'GRAMS' ) ),
);
$r = $this->mapper->map_product_data( $vp );
$v1 = $r['variations'][0];
$this->assertEquals( '22.00', $v1['regular_price'] );
$this->assertEquals( '20.00', $v1['sale_price'] );
$this->assertEquals( 'outofstock', $v1['stock_status'] );
$this->assertIsFloat( $v1['weight'] );

---

345-373: Tags mapping verified; add deduplication/normalization case

Consider adding a case with duplicate/mixed-case tags (e.g., 'Summer', 'summer') to ensure deduplication and consistent slug normalization.

---

396-439: Images mapping is strong; add fallbacks and reordering scenarios

Add tests for:

• No featuredMedia: first media should be featured.
• Missing altText: fall back to product title or empty string.
• Non-image media nodes are skipped gracefully.

Example:

$p = $this->create_simple_shopify_product();
unset( $p->featuredMedia );
$p->media = (object) array(
    'edges' => array(
        (object) array( 'node' => (object) array(
            'id' => 'gid://shopify/MediaImage/1',
            'image' => (object) array( 'url' => 'https://example.com/1.jpg', 'altText' => null ),
        ) ),
        (object) array( 'node' => (object) array(
            'id' => 'gid://shopify/MediaImage/2',
            'image' => (object) array( 'url' => 'https://example.com/2.jpg', 'altText' => 'Second' ),
        ) ),
    ),
);
$r = $this->mapper->map_product_data( $p );
$this->assertTrue( $r['images'][0]['is_featured'] );
$this->assertNotEmpty( $r['images'][0]['alt'] ); // or equals product title if that’s the policy

---

460-485: Metafields mapping looks correct; test non-string and JSON values

Add cases where metafield values are numbers, booleans, or JSON strings to verify normalization/serialization rules.

Example:

$p = $this->create_simple_shopify_product();
$p->metafields = (object) array( 'edges' => array(
    (object) array( 'node' => (object) array( 'namespace' => 'specs', 'key' => 'rating', 'value' => 4.5 ) ),
    (object) array( 'node' => (object) array( 'namespace' => 'data', 'key' => 'json', 'value' => '{"a":1}' ) ),
) );
$r = $this->mapper->map_product_data( $p );
$this->assertArrayHasKey( 'specs_rating', $r['metafields'] );
$this->assertArrayHasKey( 'data_json', $r['metafields'] );

---

490-503: Strengthen selective fields behavior assertions

You assert sku is omitted. Also assert non-requested groups are omitted (e.g., images, tags, categories, variations for simple products).

Suggested additions:

 $this->assertEquals( '25.00', $result['regular_price'] );
 
 // Should not have SKU key because 'sku' not in fields.
 $this->assertArrayNotHasKey( 'sku', $result );
+// Should not include other non-requested keys.
+$this->assertArrayNotHasKey( 'images', $result );
+$this->assertArrayNotHasKey( 'categories', $result );
+$this->assertArrayNotHasKey( 'tags', $result );
+$this->assertArrayNotHasKey( 'metafields', $result );
+$this->assertArrayNotHasKey( 'variations', $result );

---

569-637: Helpers are clear and comprehensive

Fixtures are well structured for simple and variable products. Consider adding an optional parameter to toggle common toggles (e.g., add weight/inventory/seo/media) to reduce duplication across tests.

Configuration used: .coderabbit.yml
Review profile: CHILL
Plan: Pro