Fix loading wc admin scripts on unrelated WP admin pages #57186

louwie17 · 2025-04-11T13:48:22Z

Fix admin script loading condition in WCAdminSharedSettings

Updated the admin script enqueue logic to check if the current page is an admin or embed page before loading the deprecation scripts. This improves performance by preventing unnecessary script loading on non-relevant pages.

Add changelog

Submission Review Guidelines:

I have followed the WooCommerce Contributing Guidelines and the WordPress Coding Standards.
I have checked to ensure there aren't other open Pull Requests for the same update/change.
I have reviewed my code for security best practices.
Following the above guidelines will result in quick merges and clear and detailed feedback when appropriate.

Changes proposed in this Pull Request:

Note: this is already merged to trunk, but the issue also exists in the 9.8 release, see this issue for example: #57183

WC 9.8 (PR: #55707) introduced a bug where the settings-deprecation script is loaded on all admin pages without any condition, so all its dependencies are also loaded.

This PR adds a condition to check if the current page is an admin or embed page before loading deprecation scripts to ensure we only load the script on relevant pages.

Screenshots or screen recordings:

Before	After

How to test the changes in this Pull Request:

Using the WooCommerce Testing Instructions Guide, include your detailed testing instructions:

Navigate to any non WooCommerce page in WordPress (e.g., Settings > General)
Check browser's network tab
Verify that /woocommerce/assets/client/admin scripts not being loaded
Go to WooCommerce admin pages
Verify that wcsettings-deprecation.js is still being loaded correctly
Install and activate the Speed Optimizer by Siteground plugin
Go to Speed Optimizer > Dashboard
Open your console and make sure there are no JS errors

Testing that has already taken place:

Changelog entry

Automatically create a changelog entry from the details below.

This Pull Request does not require a changelog entry. (Comment required below)

Changelog Entry Details

Significance

Patch
Minor
Major

Type

Fix - Fixes an existing bug
Add - Adds functionality
Update - Update existing functionality
Dev - Development related task
Tweak - A minor adjustment to the codebase
Performance - Address performance issues
Enhancement - Improvement to existing functionality

Message

Changelog Entry Comment

Comment

* Fix admin script loading condition in WCAdminSharedSettings Updated the admin script enqueue logic to check if the current page is an admin or embed page before loading the deprecation scripts. This improves performance by preventing unnecessary script loading on non-relevant pages. * Add changelog

github-actions · 2025-04-11T13:48:46Z

Testing Guidelines

Hi @Aljullu ,

Apart from reviewing the code changes, please make sure to review the testing instructions (Guide) and verify that relevant tests (E2E, Unit, Integration, etc.) have been added or updated as needed.

Reminder: PR reviewers are required to document testing performed. This includes:

🖼️ Screenshots or screen recordings.
📝 List of functionality tested / steps followed.
🌐 Site details (environment attributes such as hosting type, plugins, theme, store size, store age, and relevant settings).
🔍 Any analysis performed, such as assessing potential impacts on environment attributes and other plugins, conducting performance profiling, or using LLM/AI-based analysis.

⚠️ Within the testing details you provide, please ensure that no sensitive information (such as API keys, passwords, user data, etc.) is included in this public issue.

github-actions · 2025-04-11T13:55:46Z

Test using WordPress Playground

The changes in this pull request can be previewed and tested using a WordPress Playground instance.
WordPress Playground is an experimental project that creates a full WordPress instance entirely within the browser.

Test this pull request with WordPress Playground.

Note that this URL is valid for 30 days from when this comment was last updated. You can update it by closing/reopening the PR or pushing a new commit.

Aljullu

Thanks for working on this, @louwie17! Code changes look good to me. I tested with the Speed Controller by SiteGround plugin and confirmed the error is gone:

Before	After

Testing environment

WordPress 6.8-RC3 local dev environment
Plugins: WooCommerce, WooCommerce Beta Tester, WordPress Beta Tester and Speed Controller by SiteGround
Theme: Twenty Twenty-Five
Store creation: April 6th 2025
Store size: small

ysc711 · 2025-04-20T13:18:50Z

WooCommerce 9.8.1 breaks compatibility with WPCodeBox 2, and we cannot access it now as shown in the attached photo. The support of WPCodeBox 2 said it is waiting for WooCommerce to rollout the fix at #57186 in order to resolve the issues. May we know when the new fixes will be rolled out ? Thank you.

Aljullu · 2025-04-22T15:44:17Z

Hi there, @ysc711. WooCommerce 9.8.2 has just been released including this fix.

ysc711 · 2025-04-22T15:45:22Z

Hi woocommerce/woocommerce, Thanks for contacting us ! Your request (#010015693) has been received and is being reviewed by our Support Team and we'll get back to you as soon as we can. In the meantime, here are some FAQs that may assist you quickly: ========================================== Question 1: How to track my shipping status ? Please input your tracking no. by clicking this link. Your tracking no. can be found in an email generated by our system automatically after you have placed the order. Please check your spam folder if you cannot find the email in your Inbox. Question 2: How long will your support reply to my email ? We will try to respond to your email in 24 hours. Thank you very much for your patience. Question 3: How to check the product details ? Please visit our store at https://iSmartHomeGadgets.com. You can either check the top menu bar or 12 collections at the bottom based on the product categorization. You can also search for the product name via the 🔍 icon at the top right corner. Question 4: How can I place a bulk order for wholesale ? Please send your purchase list to us, which should include product name, quantity and other special requests (if any). You can get in touch with us at ***@***.*** =========================================== If you cannot find your answers above, please be assured that our support team will get back to you as soon as possible. We wish you and your family stay safe, healthy and all the best :) Best Regards, Sophia iSmart Home Gadgets https://iSmartHomeGadgets.com

louwie17 self-assigned this Apr 11, 2025

louwie17 requested a review from Aljullu April 11, 2025 13:48

github-actions bot added the plugin: woocommerce Issues related to the WooCommerce Core plugin. label Apr 11, 2025

louwie17 mentioned this pull request Apr 11, 2025

[PRR]: Fix loading wc admin scripts on unrelated WP admin pages #57187

Closed

11 tasks

Aljullu approved these changes Apr 11, 2025

View reviewed changes

jorgeatorres merged commit 889e01b into release/9.8 Apr 14, 2025
34 checks passed

jorgeatorres deleted the fix/wooplug-3876-woocommerce-loading-clientadmin-scripts-on-unrelated-wp branch April 14, 2025 07:29

github-actions bot added cherry pick to trunk Dev only - Part of CFE, PRR flows cherry pick to frozen release Dev only - Part of PRR flow labels Apr 14, 2025

jorgeatorres mentioned this pull request Apr 14, 2025

9.8 sync with trunk #57226

Merged

6 tasks

gigitux mentioned this pull request Apr 14, 2025

WooCommerce 9.8.1 breaks compatibility with SiteGround Optimizer, WooPayments, and Printdoors #57183

Closed

5 tasks

jorgeatorres changed the title ~~Fix loading wc admin scripts on unrelated WP admin pages (#57150)~~ Fix loading wc admin scripts on unrelated WP admin pages Apr 17, 2025

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Fix loading wc admin scripts on unrelated WP admin pages #57186

Fix loading wc admin scripts on unrelated WP admin pages #57186

Uh oh!

louwie17 commented Apr 11, 2025

Uh oh!

github-actions bot commented Apr 11, 2025

Uh oh!

github-actions bot commented Apr 11, 2025

Uh oh!

Aljullu left a comment

Uh oh!

Uh oh!

ysc711 commented Apr 20, 2025

Uh oh!

Aljullu commented Apr 22, 2025

Uh oh!

ysc711 commented Apr 22, 2025 via email

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

6 participants

Fix loading wc admin scripts on unrelated WP admin pages #57186

Fix loading wc admin scripts on unrelated WP admin pages #57186

Uh oh!

Conversation

louwie17 commented Apr 11, 2025

Submission Review Guidelines:

Changes proposed in this Pull Request:

Screenshots or screen recordings:

How to test the changes in this Pull Request:

Testing that has already taken place:

Changelog entry

Significance

Type

Message

Comment

Uh oh!

github-actions bot commented Apr 11, 2025

Testing Guidelines

Uh oh!

github-actions bot commented Apr 11, 2025

Test using WordPress Playground

Uh oh!

Aljullu left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

ysc711 commented Apr 20, 2025

Uh oh!

Aljullu commented Apr 22, 2025

Uh oh!

ysc711 commented Apr 22, 2025 via email

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

6 participants