-
Notifications
You must be signed in to change notification settings - Fork 10.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[e2e tests] Fixes to support WP core 6.8 #56121
Conversation
… of github.com:woocommerce/woocommerce into e2e/fix-tests-with-wpcore-6.8
…ix-tests-with-wpcore-6.8
…ix-tests-with-wpcore-6.8
…ix-tests-with-wpcore-6.8
…nto e2e/fix-tests-with-wpcore-6.8
Testing GuidelinesHi @woocommerce/solaris, Apart from reviewing the code changes, please make sure to review the testing instructions (Guide) and verify that relevant tests (E2E, Unit, Integration, etc.) have been added or updated as needed. Reminder: PR reviewers are required to document testing performed. This includes:
|
Test using WordPress PlaygroundThe changes in this pull request can be previewed and tested using a WordPress Playground instance. Test this pull request with WordPress Playground. Note that this URL is valid for 30 days from when this comment was last updated. You can update it by closing/reopening the PR or pushing a new commit. |
Thank you so much for working on this @adimoldovan. The tests passed on my end as well with the following WP and Gutenberg combinations: WP 6.8 beta ✅ Tested it locally by running: export WP_ENV_CORE="https://wordpress.org/wordpress-6.8-beta1.zip"
# commands to build and launch env
pnpm test:e2e cart/cart.spec.js \
checkout/checkout.spec.js \
coupons/cart-block-coupons.spec.js \
coupons/checkout-block-coupons.spec.js \
editor/create-woocommerce-blocks.spec.js \
editor/create-woocommerce-patterns.spec.js \
user/users-create.spec.js \
wp-core/create-page.spec.js
pnpm test:e2e -g "Picking a footer should trigger an update on the site preview"
pnpm test:e2e -g "Picking a header should trigger an update on the site preview"
pnpm test:e2e -g "Selecting an image should update the site preview"
pnpm test:e2e -g "can see products showcase" ![]() ![]() ![]() ![]() ![]() I noticed that the test ![]() After looking at other CI runs from |
@rodelgc yes, I noticed that too. It's on my radar. |
* Prep release/9.8 for 9.8 cycle (woocommerce#56031) Prep release/9.8 for 9.8 cycle with version bump to 9.8.0-beta.1 Co-authored-by: WooCommerce Bot <no-reply@woocommerce.com> * Release: Prepare the changelog for 9.8 (woocommerce#56035) * Delete changelog files from 9.8 release * Update the readme files for the 9.8 release * Update release date --------- Co-authored-by: WooCommerce Bot <no-reply@woocommerce.com> Co-authored-by: Jorge Torres <jorge.torres@automattic.com> * Cherry pick 56047 into frozen release: release/9.8 (woocommerce#56057) Fix combine 415 403 (woocommerce#56047) * Secure “Generate coupon code” button * Secure “Export products” button * Secure “Import products” button * Secure inline error messages * Secure link inside inline error messages * Remove “onChangeShippingMethodSelector” * Add changelog message * Secure “Read more” button * Added changelog. * Added element creation to avoid appending text to jQuery Object. --------- Co-authored-by: Alba Rincón <albarin@users.noreply.github.com> Co-authored-by: Niels Lange <info@nielslange.de> Co-authored-by: Paulo Arromba <17236129+wavvves@users.noreply.github.com> * Cherry pick 56048 into frozen release: release/9.8 (woocommerce#56060) Remove decodeEntities from the product name used on cart & checkout (woocommerce#56048) revert using RawHTML because it renders an extra div inside the <a> tag Co-authored-by: Alba Rincón <albarin@users.noreply.github.com> Co-authored-by: Alex Florisca <alex.florisca@automattic.com> * Prevent Fatal Error on malformed pagination query (woocommerce#56049) * Avoid fatal by casting page number to integer Cast page number to integer when generating aria-label to ensure proper number formatting * Add changefile(s) from automation for the following project(s): woocommerce --------- Co-authored-by: github-actions <github-actions@github.com> * Fix email accent color causing invisible text in emails (woocommerce#56061) * Use theme button background color as accent color in emails * Add changelog * Update tests * Fix textdomain loading warning in woocommerce 9 80 beta 1 (woocommerce#56133) * Refactor Email Editor Integration Initialization from using FeaturesUtil to `get_option` Using FeaturesUtil::feature_is_enabled here triggers a Translation loading early warning message on WordPress 6.8 Beta * Add change log file * Delete Transients: avoid running statements without options_to_clear. (woocommerce#56136) * Delete Transients: avoid running statements without options_to_clear. * Add changefile(s) from automation for the following project(s): woocommerce * Delete Transients: adds test case. * Fixes spelling. * Fixes _wc_delete_transients call. * Linting. * Fix linter white space * Returns early. --------- Co-authored-by: cpap <papazoglou.charalampos@gmail.com> Co-authored-by: github-actions <github-actions@github.com> Co-authored-by: Tom Cafferkey <tjcafferkey@gmail.com> * Cherry pick e2e test fixes 56083 and 56121 to 9.8 (woocommerce#56163) * [e2e-utils] Update editor-canvas locator to support updates in Gutenberg nightly (woocommerce#56083) * [e2e tests] Fixes to support WP core 6.8 (woocommerce#56121) --------- Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com> Co-authored-by: WooCommerce Bot <no-reply@woocommerce.com> Co-authored-by: Alba Rincón <albarin@users.noreply.github.com> Co-authored-by: Niels Lange <info@nielslange.de> Co-authored-by: Paulo Arromba <17236129+wavvves@users.noreply.github.com> Co-authored-by: Alex Florisca <alex.florisca@automattic.com> Co-authored-by: Luigi Teschio <gigitux@gmail.com> Co-authored-by: github-actions <github-actions@github.com> Co-authored-by: Ján Mikláš <neosinner@gmail.com> Co-authored-by: Oluwaseun Olorunsola <30554163+triple0t@users.noreply.github.com> Co-authored-by: Harris Papazoglou <hrrsppzgl@gmail.com> Co-authored-by: cpap <papazoglou.charalampos@gmail.com> Co-authored-by: Tom Cafferkey <tjcafferkey@gmail.com> Co-authored-by: Adrian Moldovan <3854374+adimoldovan@users.noreply.github.com>
Changes proposed in this Pull Request:
Updates to e2e checks to support WordPress 6.8
This should fix the following tests failing with 6.8 (28 tests in total):
How to test the changes in this Pull Request:
Build the utils package:
Run the tests:
All tests need to pass with:
Testing that has already taken place:
Tested locally:
In CI: