Skip to content

Bump e2e-test-utils-playwright package to use latest version #54635

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
alexflorisca merged 12 commits into from
Jan 24, 2025
Merged

Bump e2e-test-utils-playwright package to use latest version #54635

alexflorisca merged 12 commits into from
Jan 24, 2025

Conversation

@alexflorisca
Copy link
Contributor

@alexflorisca alexflorisca commented Jan 17, 2025

Changes proposed in this Pull Request:

This PR bumps the e2e-test-utils-playwright package to the latest version in order to include this PR from Gutenberg WordPress/gutenberg#66672 which will (hopefully) fix this flaky test #52404 (comment)

Closes #52404.

How to test the changes in this Pull Request:

Using the WooCommerce Testing Instructions Guide, include your detailed testing instructions:

Developer testing only

  1. Re-run in CI a few times and keep an eye on the flaky test mentioned above to see if it fails

Changelog entry

  • Automatically create a changelog entry from the details below.
  • This Pull Request does not require a changelog entry. (Comment required below)
Changelog Entry Details

Significance

  • Patch
  • Minor
  • Major

Type

  • Fix - Fixes an existing bug
  • Add - Adds functionality
  • Update - Update existing functionality
  • Dev - Development related task
  • Tweak - A minor adjustment to the codebase
  • Performance - Address performance issues
  • Enhancement - Improvement to existing functionality

Message

Changelog Entry Comment

Comment

Version bump of e2e-test-utils-playwright package in order to fix a flaky test

@alexflorisca alexflorisca requested a review from a team as a code owner January 17, 2025 11:57
@woocommercebot woocommercebot requested review from a team and mikejolley and removed request for a team January 17, 2025 11:58
@alexflorisca alexflorisca added type: technical debt This issue/PR represents/solves the technical debt of the project. focus: e2e tests Issues related to e2e tests Rubik Store API checkout endpoints, Mini-Cart, Cart and Checkout related issues labels Jan 17, 2025
@github-actions github-actions bot added focus: monorepo infrastructure Issues and PRs related to monorepo tooling. and removed focus: e2e tests Issues related to e2e tests labels Jan 17, 2025
@github-actions
Copy link
Contributor

github-actions bot commented Jan 17, 2025 •
edited
Loading

Hi @mikejolley, @kalessil,

Apart from reviewing the code changes, please make sure to review the testing instructions and verify that relevant tests (E2E, Unit, Integration, etc.) have been added or updated as needed.

You can follow this guide to find out what good testing instructions should look like:
https://github.com/woocommerce/woocommerce/wiki/Writing-high-quality-testing-instructions

@github-actions github-actions bot added the plugin: woocommerce Issues related to the WooCommerce Core plugin. label Jan 17, 2025
@github-actions
Copy link
Contributor

github-actions bot commented Jan 17, 2025 •
edited
Loading

Size Change: 0 B

Total Size: 5.4 MB

compressed-size-action

@github-actions
Copy link
Contributor

github-actions bot commented Jan 17, 2025 •
edited
Loading

Test using WordPress Playground

The changes in this pull request can be previewed and tested using a WordPress Playground instance.
WordPress Playground is an experimental project that creates a full WordPress instance entirely within the browser.

Test this pull request with WordPress Playground.

Note that this URL is valid for 30 days from when this comment was last updated. You can update it by closing/reopening the PR or pushing a new commit.

mikejolley
mikejolley reviewed Jan 17, 2025
View reviewed changes
Copy link
Member

@mikejolley mikejolley left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't see anything wrong with bumping this. Which test suite was it that contained the flakey test?

I did notice my lock file changed after checking out this PR, running nvm use then doing pnpm install. Is it up to date fully?

@alexflorisca
Copy link
Contributor Author

alexflorisca commented Jan 17, 2025

I'm just checking about the lockfile in the #woo-monorepo on slack (tampermonkey is broken so won't post link here). But changes should be mostly related to the version bump of the e2e-test-utils-playwright package

@alexflorisca
Copy link
Contributor Author

alexflorisca commented Jan 20, 2025

I've updated the dependency in woocommerce plugin as well. Yaml file should be good if all tests pass and there are no build errors.

kalessil
kalessil reviewed Jan 20, 2025
View reviewed changes
@alexflorisca alexflorisca requested a review from kalessil January 22, 2025 10:29
@alexflorisca
Copy link
Contributor Author

alexflorisca commented Jan 22, 2025

@mikejolley and @kalessil this is ready for another review now

kalessil
kalessil approved these changes Jan 22, 2025
View reviewed changes
Copy link
Contributor

@kalessil kalessil left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM (changes and E2E tests)!

PS: Thanks for taking the extra stretch to tweak synckpack config.

@alexflorisca alexflorisca merged commit ccc6eb8 into trunk Jan 24, 2025
104 checks passed
@alexflorisca alexflorisca deleted the update/bump-e2e-test-utils-playwright branch January 24, 2025 17:40
@github-actions github-actions bot added this to the 9.8.0 milestone Jan 24, 2025
@github-actions github-actions bot added the needs: analysis Indicates if the PR requires a PR testing scrub session. label Jan 24, 2025
@rodelgc rodelgc added status: analysis complete Indicates if a PR has been analysed by Solaris and removed needs: analysis Indicates if the PR requires a PR testing scrub session. labels Jan 27, 2025
@alexflorisca alexflorisca mentioned this pull request Feb 10, 2025
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@mikejolley mikejolley mikejolley approved these changes

@kalessil kalessil kalessil approved these changes

Assignees

No one assigned

Labels

focus: monorepo infrastructure Issues and PRs related to monorepo tooling. plugin: woocommerce Issues related to the WooCommerce Core plugin. Rubik Store API checkout endpoints, Mini-Cart, Cart and Checkout related issues status: analysis complete Indicates if a PR has been analysed by Solaris type: technical debt This issue/PR represents/solves the technical debt of the project.

Projects

None yet

Milestone

9.8.0

Development

Successfully merging this pull request may close these issues.

[Flaky Test] Merchant can transform shortcode block into blocks

5 participants

@alexflorisca @mikejolley @kalessil @rodelgc