Conversation
|
Hi @gigitux, @woocommerce/woo-fse Apart from reviewing the code changes, please make sure to review the testing instructions and verify that relevant tests (E2E, Unit, Integration, etc.) have been added or updated as needed. You can follow this guide to find out what good testing instructions should look like: |
Test using WordPress PlaygroundThe changes in this pull request can be previewed and tested using a WordPress Playground instance. Test this pull request with WordPress Playground. Note that this URL is valid for 30 days from when this comment was last updated. You can update it by closing/reopening the PR or pushing a new commit. |
gigitux
left a comment
There was a problem hiding this comment.
LGTM!
In the testing instruction, I would mention that after removing the transients, it is necessarily to cancel the fetch_patterns scheduled action to trigger the log of the error.
* Set a transient to track the logger so it only logs once-per-day
Submission Review Guidelines:
Changes proposed in this Pull Request:
Some users are experiencing their sites log file being spammed with warnings from the PTK log warnings. This PR introduces a change which sets a transient to track that the warning log only happens once per day.
https://wordpress.org/support/topic/ptk-pattern-store/page/4/
How to test the changes in this Pull Request:
Using the WooCommerce Testing Instructions Guide, include your detailed testing instructions:
/wp-admin/admin.php?page=wc-settings&tab=advanced§ion=woocommerce_com)transient ptk_patternstransient. You can do so via the Transient Manager plugin.$patterns = array()OR by deleting the transientwc_ptk_pattern_store_warningand canceling the scheduled actionfetch_patternswc_ptk_pattern_store_warningexists and that only 1 warning is in your log fileChangelog entry
Changelog Entry Details
Significance
Type
Message
Changelog Entry Comment
Comment