Skip to content

Fix search in Installed Plugins page#53196

Closed
nathanss wants to merge 4 commits intorelease/9.4from
fix/plugin-search
Closed

Fix search in Installed Plugins page#53196
nathanss wants to merge 4 commits intorelease/9.4from
fix/plugin-search

Conversation

@nathanss
Copy link
Copy Markdown
Contributor

@nathanss nathanss commented Nov 26, 2024 •
edited
Loading

Submission Review Guidelines:

Changes proposed in this Pull Request:

This fixes an issue where searching for plugins in the installed plugins page would cause an unexpected error.

Closes #53057
Closes #52931

How to test the changes in this Pull Request:

Using the WooCommerce Testing Instructions Guide, include your detailed testing instructions:

  1. Go to Plugins > Installed Plugins
  2. Search for any installed plugin by typing in the search input
  3. Verify that the search works instead of loading indefinitely

Changelog entry

  • Automatically create a changelog entry from the details below.
  • This Pull Request does not require a changelog entry. (Comment required below)
Changelog Entry Details

Significance

  • Patch
  • Minor
  • Major

Type

  • Fix - Fixes an existing bug
  • Add - Adds functionality
  • Update - Update existing functionality
  • Dev - Development related task
  • Tweak - A minor adjustment to the codebase
  • Performance - Address performance issues
  • Enhancement - Improvement to existing functionality

Message

Changelog Entry Comment

Comment

@nathanss nathanss self-assigned this Nov 26, 2024
@github-actions github-actions bot added the plugin: woocommerce Issues related to the WooCommerce Core plugin. label Nov 26, 2024
@github-actions
Copy link
Copy Markdown
Contributor

github-actions bot commented Nov 26, 2024 •
edited
Loading

Test using WordPress Playground

The changes in this pull request can be previewed and tested using a WordPress Playground instance.
WordPress Playground is an experimental project that creates a full WordPress instance entirely within the browser.

Test this pull request with WordPress Playground.

Note that this URL is valid for 30 days from when this comment was last updated. You can update it by closing/reopening the PR or pushing a new commit.

@nathanss nathanss mentioned this pull request Nov 26, 2024
Closed
10 tasks
@PanosSynetos PanosSynetos self-requested a review November 26, 2024 14:19
@github-actions
Copy link
Copy Markdown
Contributor

github-actions bot commented Nov 26, 2024 •
edited
Loading

Hi , @woocommerce/flux

Apart from reviewing the code changes, please make sure to review the testing instructions and verify that relevant tests (E2E, Unit, Integration, etc.) have been added or updated as needed.

You can follow this guide to find out what good testing instructions should look like:
https://github.com/woocommerce/woocommerce/wiki/Writing-high-quality-testing-instructions

PanosSynetos
PanosSynetos approved these changes Nov 26, 2024
View reviewed changes
Copy link
Copy Markdown
Contributor

@PanosSynetos PanosSynetos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the prompt fix @nathanss - Manually tested this and the search functionality for installed plugins now works as expected, without throwing a fatal error.

@nathanss
Copy link
Copy Markdown
Contributor Author

nathanss commented Nov 28, 2024

@woocommerce/proton Highlight Template Changes / Analyze Branch Changes job is failing even though there are no changes to templates.

@peterfabian peterfabian changed the base branch from release/9.4 to release/9.5 December 4, 2024 09:32
@peterfabian peterfabian requested a review from a team as a code owner December 4, 2024 09:32
@peterfabian peterfabian changed the base branch from release/9.5 to release/9.4 December 4, 2024 09:33
@peterfabian peterfabian removed the request for review from a team December 4, 2024 09:33
@peterfabian peterfabian mentioned this pull request Dec 4, 2024
Merged
12 tasks
@nathanss nathanss closed this Dec 4, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@PanosSynetos PanosSynetos PanosSynetos approved these changes

Assignees

@nathanss nathanss

Labels

plugin: woocommerce Issues related to the WooCommerce Core plugin.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@nathanss @PanosSynetos @jimjasson @kalessil