Coming Soon: Return empty string from template_include filter instead of null to avoid PHP fatal error with conflicting plugins using strict types #51751
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Submission Review Guidelines:
Changes proposed in this Pull Request:
I encountered a fatal error when accessing the Coming Soon page on a site that is also running the Optimization Detective plugin. The reason is that Optimization Detective adds a
template_include
filter the same as WooCommerce does, but Optimization Detective addsstring
type hint for the callback function since the filter defines the$template
param as astring
. Nevertheless,ComingSoonRequestHandler::handle_template_include()
seems to disregard this by returningstring|null
. The fix seems to simply return an empty string instead ofnull
. I've also fixed this in Optimization Detective by removing the type hint in WordPress/performance#1565, but it could be a problem with other plugins as well.How to test the changes in this Pull Request:
Using the WooCommerce Testing Instructions Guide, include your detailed testing instructions:
Changelog entry
Changelog Entry Details
Significance
Type
Message
Return an empty string from
template_include
filter instead of null to avoid PHP fatal error with conflicting plugins using strict types.Changelog Entry Comment
Comment