Cherry pick 51541 into release/9.4 #51615
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
* Minor cleanup * refact: Rename must_be_visible to is_incentive_visible for clarity * refact: Rename register_payments_welcome_page to register_menu_and_page for clarity * Don't show the incentive page if the user can't manage WC * Introduce menu item when no incentive * Don't recommend additional gateways when WCPay is present * Render gateway suggestions on the WCPay task page, also * Add changelog entry * Remove short array syntax * Lint fixes * Simplify Payments task view logic * Simplify WooPayments task view logic * Improve WooPayments task complete logic * WooPayments can't be connected or onboarded if it is not active * refact: Rename private static method * Improve logic to determine the Payments task slug by factoring in the extended task list also * docs: Add details about our use of the Payments task logic * Add type hint * Do not recommend offline methods when WooPayments is supported * On suggestion enablement redirect to the same task page * Lint fixes * test: Fix unit tests * Maintain deprecated navigation logic
github-actions
bot
added
the
metric: code freeze exception
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR cherry-picks the following PRs into the release branch: