Remove property type hints in TransientFilesEngine and ReceiptRenderingEngine #44829
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
plugin: woocommerce
vedanshujain
approved these changes
Feb 21, 2024
Contributor
Test Results SummaryCommit SHA: 8cfe801
To view the full API test report, click here. To view the full E2E test report, click here. To view all test reports, visit the WooCommerce Test Reports Dashboard. |
lsinger
suggested changes
Feb 21, 2024
Contributor
lsinger
left a comment
lsinger
left a comment
There was a problem hiding this comment.
There’s another instance of private LegacyProxy $legacy_proxy in plugins/woocommerce/src/Internal/ReceiptRendering/ReceiptRenderingEngine.php. Let's remove that as well.
Konamiman
changed the title
Konamiman
deleted the
remove_type_hint_in_property_in_transient_files_engine
branch
github-actions
bot
added
the
needs: analysis
veljkho
added
status: analysis complete
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes proposed in this Pull Request:
A user is reporting the following error after upgrading to WooCommerce 8.6:
While this looks like an error due to WooCommerce running in PHP 7.3 or older, the fact is that this is actually happening in PHP 7.4.
At this point it's not clear why this is happening, but for now the type hint is being removed, so that the transient files engine (which is a dependency of the receipts printing engine) doesn't break. Similar type hints in
ReceiptRenderingEngineare removed too.How to test the changes in this Pull Request:
Running the unit tests should be enough. Optionally, you can also repeat the tests of #43502.
Changelog entry
Significance
Type
Message
Comment