[Product Block Editor]: Add `Linked product` tab #43009

retrofox · 2023-12-20T19:14:06Z

Submission Review Guidelines:

I have followed the WooCommerce Contributing Guidelines and the WordPress Coding Standards.
I have checked to ensure there aren't other open Pull Requests for the same update/change.
I have reviewed my code for security best practices.
Following the above guidelines will result in quick merges and clear and detailed feedback when appropriate.

Changes proposed in this Pull Request:

This PR registers the new Linked Product only when the linked-product flag is enabled.

Depends on #43006
Part of #42915
Closes # .

How to test the changes in this Pull Request:

Using the WooCommerce Testing Instructions Guide, include your detailed testing instructions:

Go to Tools > WCA Test Helper
Go to the Features tab
Enable the product-linked flag

Go to the block editor
Confirm that you see the new Linked Product tab

Changelog entry

Automatically create a changelog entry from the details below.

Details

Significance

Patch
Minor
Major

Type

Fix - Fixes an existing bug
Add - Adds functionality
Update - Update existing functionality
Dev - Development related task
Tweak - A minor adjustment to the codebase
Performance - Address performance issues
Enhancement - Improvement to existing functionality

Message

Comment

github-actions · 2023-12-20T19:22:16Z

Test Results Summary

Commit SHA: 0605d7f

Test 🧪	Passed ✅	Failed 🚨	Broken 🚧	Skipped ⏭️	Unknown ❔	Total 📊	Duration ⏱️
API Tests	259	0	0	2	0	261	0m 37s
E2E Tests	258	0	0	3	0	261	14m 18s

To view the full API test report, click here.
To view the full E2E test report, click here.
To view all test reports, visit the WooCommerce Test Reports Dashboard.

github-actions · 2023-12-20T19:44:43Z

Hi , @woocommerce/mothra

Apart from reviewing the code changes, please make sure to review the testing instructions as well.

You can follow this guide to find out what good testing instructions should look like:
https://github.com/woocommerce/woocommerce/wiki/Writing-high-quality-testing-instructions

mdperez86

Nice job @retrofox, I left some comments.

...commerce/src/Internal/Features/ProductBlockEditor/ProductTemplates/SimpleProductTemplate.php

mdperez86

Do not agree merging code that is not aligned with the ACs of the issue but you can cover this in the next PR as you mentioned.

...commerce/src/Internal/Features/ProductBlockEditor/ProductTemplates/SimpleProductTemplate.php

retrofox · 2023-12-21T19:00:29Z

Do not agree merging code that is not aligned with the ACs of the issue but you can cover this in the next PR as you mentioned.

Ok, I'll try to avoid that in the future.

I am requesting this because I believe we are currently in the midst of the development process, which means we can quickly make changes and updates to the code. For me, it's good that we maintain the momentum of our development and not lose it.

I have another PR branched off from this one. Adding a change here will require updating the following one, which isn't a big deal either. So as long as it doesn't add breaking changes, it's fine to continue in a follow-up.

Also, I'm learning while I write the code. So I prefer to keep things small for now.

Thanks for your approval 🙇‍♂️

* add linked-products to group IDs * add Linked Products tab * tweak hideConditions condition * changelog * fix typo in doc comment

…s documentation (#43055) * Update woocommerce.com URLs in documentation and code files * Add changelog * Fix github repository link in extend-rest-api-add-custom-fields.md Co-authored-by: Albert Juhé Lluveras <[email protected]> * Add github reporter (#42974) * Add github reporter * Add changelog --------- Co-authored-by: Jon Lane <[email protected]> * Fix product task redirect to support grouped and external products (#43051) * Rearrange product redirection logic to better accept grouped and external produc types * Add changelog * Modify feedback modal actions (#43005) * Adapt feedback modal actions * Add changelogs * Modify comments * Fix tests * Fix test * Update class-wc-gateway-bacs.php (#43054) * Update class-wc-gateway-bacs.php Fix typo in textdomain * Add changefile(s) from automation for the following project(s): woocommerce --------- Co-authored-by: github-actions <[email protected]> * [Product Block Editor]: Add `Linked product` tab (#43009) * add linked-products to group IDs * add Linked Products tab * tweak hideConditions condition * changelog * fix typo in doc comment * Introduce a product type selection within the new experience (#41823) * Create a relation between the product type and the product block template * Add 'patterns' to name the kind of products that can be created for a specific template * Resolve template using its id as a template query param * Rename ProductEditPattern to ProductTemplate * Rename get_patterns hook to woocommerce_product_editor_get_product_templates * Return the list of templates to the client * Set layout template events as array * Register the layout template based on the product template or the post type in case of product variations * Registering non supported product types * Create and register the woocommerce/product-details-section-description block * Add the product type to the section description * Create product type selector * Fix menu item style * Highlight selected menu item * Set the selected product template * Set product template title to lowercase in the content description * Rename blocks by blockTemplates under the AbstractBlockTemplate class * Rename to woocommerce_product_editor_product_templates filter * Remove product_template_ prefix from the supported_product_types map * Rename get_formatted to to_JSON and convert the props to client side like * Refactor get_product_templates * Fix icon resolution * Add a confirmation modal for unsupported product templates * Add changelog files * Remove product types using for testing * Fix redirection when changing to a non supported product template * Set the change button state to busy when it is saving the product * Fix php linter errors * Fix rebase conflict * Move ProductTemplate to Automattic\WooCommerce\Admin\Features\ProductBlockEditor namespace * Add the to_json definition to the BlockTemplateInterface * Create default product template by custom product type if it does not have a template associated yet * Fix some comments and product template creation validation * Add support to load the product template icon from an external resource * Fix php linter * Fix the changelog description * [Experimental] Interactivity Dropdown multi-select mode, ratings filter and introduce each directive (#42981) --------- Co-authored-by: David Arenas <[email protected]> * Introduce the transient files engine (#42877) Co-authored-by: Corey McKrill <[email protected]> * Change marketplace install API request to POST instead of GET (#43033) * Change marketplace install API to using POST instead of GET * Fix linting error * Add changefile(s) from automation for the following project(s): woocommerce --------- Co-authored-by: github-actions <[email protected]> * Prep trunk for 8.6 cycle (#43021) Prep trunk for 8.6 cycle with version bump to 8.6.0-dev Co-authored-by: WooCommerce Bot <[email protected]> * Add Playwright tests for All Reviews, Reviews by Product and Reviews by Category blocks (#42903) * Remove Reviews blocks Puppeteer tests * Minor code cleanup * Typos * Create publishAndVisitPost() editor util * Fix subcategories when importing products in Playwright and add reviews * Add Reviews blocks tests in Playwright * More typos * Add changefile(s) from automation for the following project(s): woocommerce-blocks * Create a 'reviews' object in data.ts so we can store reviews data in one single place * Update test so instead of creating a new post in each test, we go to the already-created post * Add source comments to reviews data to match it with the script --------- Co-authored-by: github-actions <[email protected]> * Release: Remove 8.5 change files (#43022) Delete changelog files from 8.5 release Co-authored-by: WooCommerce Bot <[email protected]> Co-authored-by: Alex López <[email protected]> * Delete changelog files based on PR 43033 (#43079) Delete changelog files for 43033 Co-authored-by: WooCommerce Bot <[email protected]> * Delete changelog files based on PR 43051 (#43081) Delete changelog files for 43051 Co-authored-by: WooCommerce Bot <[email protected]> * Interactive Price Filter: use `context` instead of `state` (#42980) * feat: use context instead of state * fix: temporary move the context to inner element for diffing to work * fix: update context before navigation for optimistic UI * Load google analytics gtag script asynchronously in WooCommerce Blocks (#43040) Co-authored-by: github-actions <[email protected]> * set WOOCOMMERCE_BLOCKS_PHASE to 1 for the production build (#43074) * set WOOCOMMERCE_BLOCKS_PHASE to 1 for the production build * Add changefile(s) from automation for the following project(s): woocommerce --------- Co-authored-by: github-actions <[email protected]> * Revert "Fix schedule sales error" (#43094) Revert "Fix schedule sales error (#42700)" This reverts commit 9b800aa. * [Product Block Editor]: add Linked product sections. First approach. (#43013) * add Linked products, Upsell section * changelog * add Cross-lens section * add links to the Upsell sections * changelog * fix lint issues * fix lint issus * fix linting issue :-| * check whether the linked product group is defined * [Product Block Editor]: introduce ShoppingBags component (#43042) * add ShoppingBags component * Add ShoppingBag story * changelog * Fix: Collection data being leaked between Collection Filters blocks (#43044) * fix: CYS - change heading color (#43076) * fix: CYS - change heading color * Add changefile(s) from automation for the following project(s): woocommerce --------- Co-authored-by: github-actions <[email protected]> Co-authored-by: Patricia Hillebrandt <[email protected]> * Delete changelog files based on PR 43074 (#43118) Delete changelog files for 43074 Co-authored-by: WooCommerce Bot <[email protected]> * [Product Block Editor]: fix feature flag to hide the Linked products (#43119) * fix flag to hide/show product editor * changelog * Add changelog --------- Co-authored-by: Albert Juhé Lluveras <[email protected]> Co-authored-by: Jonathan Lane <[email protected]> Co-authored-by: Jon Lane <[email protected]> Co-authored-by: louwie17 <[email protected]> Co-authored-by: Fernando Marichal <[email protected]> Co-authored-by: Marc Guay <[email protected]> Co-authored-by: github-actions <[email protected]> Co-authored-by: Damián Suárez <[email protected]> Co-authored-by: Maikel David Pérez Gómez <[email protected]> Co-authored-by: Sam Seay <[email protected]> Co-authored-by: Néstor Soriano <[email protected]> Co-authored-by: Corey McKrill <[email protected]> Co-authored-by: Kyle Nel <[email protected]> Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com> Co-authored-by: WooCommerce Bot <[email protected]> Co-authored-by: Alex López <[email protected]> Co-authored-by: Tung Du <[email protected]> Co-authored-by: Thomas Roberts <[email protected]> Co-authored-by: Luigi Teschio <[email protected]> Co-authored-by: Patricia Hillebrandt <[email protected]>

retrofox added focus: new product ux labels Dec 20, 2023

retrofox self-assigned this Dec 20, 2023

github-actions bot added the plugin: woocommerce Issues related to the WooCommerce Core plugin. label Dec 20, 2023

retrofox force-pushed the update/product-editor-add-product-linked-tab branch from a59f393 to a5dfd1c Compare December 20, 2023 19:18

retrofox force-pushed the update/product-editor-add-product-linked-tab branch from a5dfd1c to 0406517 Compare December 20, 2023 19:23

retrofox requested a review from a team December 20, 2023 19:44

retrofox added 4 commits December 20, 2023 16:55

add linked-products to group IDs

9f14c44

add Linked Products tab

3fc6f34

tweak hideConditions condition

355ce99

changelog

ed6ca46

retrofox force-pushed the update/product-editor-add-product-linked-tab branch from 0406517 to ed6ca46 Compare December 20, 2023 19:56

retrofox mentioned this pull request Dec 20, 2023

[Product Block Editor]: add Linked product sections. First approach. #43013

Merged

11 tasks

mdperez86 suggested changes Dec 20, 2023

View reviewed changes

...commerce/src/Internal/Features/ProductBlockEditor/ProductTemplates/SimpleProductTemplate.php Outdated Show resolved Hide resolved

...commerce/src/Internal/Features/ProductBlockEditor/ProductTemplates/SimpleProductTemplate.php Show resolved Hide resolved

fix typo in doc comment

0605d7f

mdperez86 approved these changes Dec 21, 2023

View reviewed changes

...commerce/src/Internal/Features/ProductBlockEditor/ProductTemplates/SimpleProductTemplate.php Show resolved Hide resolved

retrofox merged commit eac1a46 into trunk Dec 21, 2023

retrofox deleted the update/product-editor-add-product-linked-tab branch December 21, 2023 19:00

github-actions bot added this to the 8.6.0 milestone Dec 21, 2023

github-actions bot added the needs: analysis Indicates if the PR requires a PR testing scrub session. label Dec 21, 2023

veljkho added needs: internal testing Indicates if the PR requires further testing conducted by Solaris status: analysis complete Indicates if a PR has been analysed by Solaris and removed needs: analysis Indicates if the PR requires a PR testing scrub session. labels Dec 22, 2023

thealexandrelara pushed a commit that referenced this pull request Dec 26, 2023

[Product Block Editor]: Add Linked product tab (#43009)

be09729

* add linked-products to group IDs * add Linked Products tab * tweak hideConditions condition * changelog * fix typo in doc comment

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

[Product Block Editor]: Add `Linked product` tab #43009

[Product Block Editor]: Add `Linked product` tab #43009

Uh oh!

retrofox commented Dec 20, 2023 •

edited

Loading

Uh oh!

github-actions bot commented Dec 20, 2023 •

edited

Loading

Uh oh!

github-actions bot commented Dec 20, 2023

Uh oh!

mdperez86 left a comment

Uh oh!

Uh oh!

Uh oh!

mdperez86 left a comment

Uh oh!

Uh oh!

retrofox commented Dec 21, 2023

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

[Product Block Editor]: Add Linked product tab #43009

[Product Block Editor]: Add Linked product tab #43009

Uh oh!

Conversation

retrofox commented Dec 20, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Submission Review Guidelines:

Changes proposed in this Pull Request:

How to test the changes in this Pull Request:

Changelog entry

Significance

Type

Message

Comment

Uh oh!

github-actions bot commented Dec 20, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Test Results Summary

Uh oh!

github-actions bot commented Dec 20, 2023

Uh oh!

mdperez86 left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

mdperez86 left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

retrofox commented Dec 21, 2023

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

[Product Block Editor]: Add `Linked product` tab #43009

[Product Block Editor]: Add `Linked product` tab #43009

retrofox commented Dec 20, 2023 •

edited

Loading

github-actions bot commented Dec 20, 2023 •

edited

Loading